Skip to content

Commit 7cb0604

Browse files
author
m.zharinova
committed
combine outputs, add test retries
1 parent 484231d commit 7cb0604

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

buildSrc/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ dependencies {
1313
implementation("gradle.plugin.com.google.gradle:osdetector-gradle-plugin:1.7.3")
1414
implementation("de.thetaphi:forbiddenapis:3.8")
1515
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:6.1.0")
16+
implementation("org.gradle:test-retry-gradle-plugin:1.6.1")
1617
}

buildSrc/src/main/kotlin/sb-ot-demo.java-conventions.gradle.kts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ plugins {
1818
id("com.github.spotbugs")
1919
id("net.ltgt.errorprone")
2020
id("com.google.osdetector")
21+
id("org.gradle.test-retry")
2122
}
2223

2324
dependencies {
@@ -95,6 +96,12 @@ tasks {
9596
dependsOn(checkstyleMain, checkstyleTest, pmdMain, pmdTest, spotbugsMain, spotbugsTest)
9697
finalizedBy(jacocoTestReport, jacocoTestCoverageVerification)
9798
maxParallelForks = 1
99+
100+
retry {
101+
maxRetries.set(1)
102+
maxFailures.set(3)
103+
failOnPassedAfterRetry.set(false)
104+
}
98105
}
99106

100107
jacocoTestCoverageVerification {

spring-boot-2-demo-app/src/test/java/io/github/mfvanek/spring/boot2/test/service/PublicApiServiceTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ void getZonedTimeSuccessfully(@Nonnull final CapturedOutput output) throws JsonP
5656
assertThat(result).isNotNull();
5757
assertThat(result.truncatedTo(ChronoUnit.MINUTES))
5858
.isEqualTo(localDateTimeNow.truncatedTo(ChronoUnit.MINUTES));
59-
assertThat(output).doesNotContain(
59+
assertThat(output.getAll()).doesNotContain(
6060
"Retrying request to ",
6161
"Retries exhausted",
6262
"Failed to convert response ",
@@ -78,8 +78,7 @@ void retriesOnceToGetZonedTime(@Nonnull final CapturedOutput output) throws Json
7878
verify(2, getRequestedFor(urlPathMatching("/" + zoneNames)));
7979

8080
assertThat(result).isNull();
81-
assertThat(output).contains("Retrying request to ", "Retries exhausted");
82-
assertThat(output).doesNotContain("Failed to convert response ");
83-
assertThat(output).contains("\"instance_timezone\":\"" + zoneNames + "\"");
81+
assertThat(output.getAll()).contains("Retrying request to ", "Retries exhausted", "\"instance_timezone\":\"" + zoneNames + "\"");
82+
assertThat(output.getAll()).doesNotContain("Failed to convert response ");
8483
}
8584
}

spring-boot-3-demo-app/src/test/java/io/github/mfvanek/spring/boot3/test/controllers/TimeControllerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,7 @@ void mdcValuesShouldBeReportedInRetryLogs(@Nonnull final CapturedOutput output)
217217
.until(() -> countRecordsInTable() >= 1L);
218218
assertThat(output.getAll())
219219
.contains("Received record: " + received.value() + " with traceId " + traceId);
220-
assertThat(output).contains("Retrying request to ", "Retries exhausted");
221-
assertThat(output).contains("\"instance_timezone\":\"" + zoneNames + "\"");
220+
assertThat(output.getAll()).contains("Retrying request to ", "Retries exhausted", "\"instance_timezone\":\"" + zoneNames + "\"");
222221
final String messageFromDb = namedParameterJdbcTemplate.queryForObject("select message from otel_demo.storage where trace_id = :traceId",
223222
Map.of("traceId", traceId), String.class);
224223
assertThat(messageFromDb)

spring-boot-3-demo-app/src/test/java/io/github/mfvanek/spring/boot3/test/service/PublicApiServiceTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ void printTimeZoneSuccessfully(@Nonnull final CapturedOutput output) throws Json
5656
assertThat(result).isNotNull();
5757
assertThat(result.truncatedTo(ChronoUnit.MINUTES))
5858
.isEqualTo(localDateTimeNow.truncatedTo(ChronoUnit.MINUTES));
59-
assertThat(output).doesNotContain(
59+
assertThat(output.getAll()).doesNotContain(
6060
"Retrying request to ",
6161
"Retries exhausted",
6262
"Failed to convert response ",
@@ -78,8 +78,7 @@ void retriesOnceToGetZonedTime(@Nonnull final CapturedOutput output) throws Json
7878
verify(2, getRequestedFor(urlPathMatching("/" + zoneNames)));
7979

8080
assertThat(result).isNull();
81-
assertThat(output).contains("Retrying request to ", "Retries exhausted");
82-
assertThat(output).doesNotContain("Failed to convert response ");
83-
assertThat(output).contains("\"instance_timezone\":\"" + zoneNames + "\"");
81+
assertThat(output.getAll()).contains("Retrying request to ", "Retries exhausted", "\"instance_timezone\":\"" + zoneNames + "\"");
82+
assertThat(output.getAll()).doesNotContain("Failed to convert response ");
8483
}
8584
}

0 commit comments

Comments
 (0)