Skip loadInclude if baseName is not resolveable (#548)

Co-authored-by: Matt Glaman <[email protected]>

Author: Boegie

src/Rules/Drupal/LoadIncludeBase.php

@@ -6,7 +6,6 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
-use PHPStan\Type\Constant\ConstantStringType;
 
 abstract class LoadIncludeBase implements Rule
 {
@@ -24,8 +23,9 @@ public function __construct(ExtensionMap $extensionMap)
     private function getStringArgValue(Node\Expr $expr, Scope $scope): ?string
     {
         $type = $scope->getType($expr);
-        if ($type instanceof ConstantStringType) {
-            return $type->getValue();
+        $stringTypes = $type->getConstantStrings();
+        if (count($stringTypes) > 0) {
+            return $stringTypes[0]->getValue();
         }
         return null;
     }
@@ -43,6 +43,9 @@ protected function parseLoadIncludeArgs(Node\Arg $module, Node\Arg $type, ?Node\
         $baseName = null;
         if ($name !== null) {
             $baseName = $this->getStringArgValue($name->value, $scope);
+            if ($baseName === null) {
+                return [false, false];
+            }
         }
         if ($baseName === null) {
             $baseName = $moduleName;

tests/src/Rules/LoadIncludesRuleTest.php

@@ -45,6 +45,11 @@ public function cases(): \Generator
             [__DIR__.'/data/bug-516.php'],
             []
         ];
+
+        yield 'bug-547.php' => [
+            [__DIR__.'/data/bug-547.php'],
+            []
+        ];
     }
 
 }

tests/src/Rules/data/bug-547.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Bug547;
+
+/**
+ * Tests moduleHandler::loadInclude where $name argument includes a variable.
+ */
+class TestClass {
+
+    /**
+     * Code snippet from core/modules/system/tests/modules/entity_test/entity_test.install.
+     */
+    function bug547(): void
+    {
+        $module_handler = \Drupal::moduleHandler();
+        $index = \Drupal::state()->get('entity_test.db_updates.entity_definition_updates');
+        $module_handler->loadInclude('entity_test', 'inc', 'update/entity_definition_updates_' . $index);
+    }
+
+}
+