Add implements generics to all Rule implementations and remove associated assert() calls. (#719)

Author: mad-briller

src/Rules/Classes/ClassExtendsInternalClassRule.php

@@ -11,6 +11,9 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use function sprintf;
 
+/**
+ * @implements Rule<Class_>
+ */
 class ClassExtendsInternalClassRule implements Rule
 {
     /**
@@ -30,7 +33,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        /** @var Class_ $node */
         if (!isset($node->extends)) {
             return [];
         }

src/Rules/Deprecations/AccessDeprecatedConstant.php

@@ -12,6 +12,9 @@
 use function explode;
 use function sprintf;
 
+/**
+ * @implements Rule<Node\Expr\ConstFetch>
+ */
 class AccessDeprecatedConstant implements Rule
 {
     /** @var ReflectionProvider */
@@ -28,7 +31,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof Node\Expr\ConstFetch);
         if (DeprecatedScopeCheck::inDeprecatedScope($scope)) {
             return [];
         }

src/Rules/Deprecations/ConditionManagerCreateInstanceContextConfigurationRule.php

@@ -12,6 +12,9 @@
 use PHPStan\Type\ObjectType;
 use function count;
 
+/**
+ * @implements Rule<Node\Expr\MethodCall>
+ */
 final class ConditionManagerCreateInstanceContextConfigurationRule implements Rule
 {
     public function getNodeType(): string
@@ -21,7 +24,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof Node\Expr\MethodCall);
         if (!$node->name instanceof Node\Identifier) {
             return [];
         }

src/Rules/Deprecations/DeprecatedAnnotationsRuleBase.php

@@ -8,6 +8,9 @@
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 
+/**
+ * @implements Rule<Node\Stmt\Class_>
+ */
 abstract class DeprecatedAnnotationsRuleBase implements Rule
 {
 
@@ -36,7 +39,6 @@ abstract protected function doProcessNode(
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof Node\Stmt\Class_);
         if ($node->extends === null) {
             return [];
         }

src/Rules/Deprecations/DeprecatedHookImplementation.php

@@ -14,6 +14,9 @@
 use function strlen;
 use function substr_replace;
 
+/**
+ * @implements Rule<Function_>
+ */
 class DeprecatedHookImplementation implements Rule
 {
 
@@ -31,7 +34,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope) : array
     {
-        assert($node instanceof Function_);
         if (!str_ends_with($scope->getFile(), ".module") && !str_ends_with($scope->getFile(), ".inc")) {
             return [];
         }

src/Rules/Deprecations/GetDeprecatedServiceRule.php

@@ -8,6 +8,9 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 
+/**
+ * @implements Rule<Node\Expr\MethodCall>
+ */
 final class GetDeprecatedServiceRule implements Rule
 {
 
@@ -28,7 +31,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof Node\Expr\MethodCall);
         if (!$node->name instanceof Node\Identifier) {
             return [];
         }

src/Rules/Deprecations/StaticServiceDeprecatedServiceRule.php

@@ -8,6 +8,9 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 
+/**
+ * @implements Rule<Node\Expr\StaticCall>
+ */
 final class StaticServiceDeprecatedServiceRule implements Rule
 {
 
@@ -28,7 +31,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof Node\Expr\StaticCall);
         if (!$node->name instanceof Node\Identifier) {
             return [];
         }

src/Rules/Deprecations/SymfonyCmfRouteObjectInterfaceConstantsRule.php

@@ -13,6 +13,9 @@
 use Symfony\Cmf\Component\Routing\RouteObjectInterface as SymfonyRouteObjectInterface;
 use function sprintf;
 
+/**
+ * @implements Rule<Node\Expr\ClassConstFetch>
+ */
 final class SymfonyCmfRouteObjectInterfaceConstantsRule implements Rule
 {
 
@@ -23,7 +26,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof Node\Expr\ClassConstFetch);
         if (!$node->name instanceof Node\Identifier) {
             return [];
         }

src/Rules/Deprecations/SymfonyCmfRoutingInClassMethodSignatureRule.php

@@ -17,6 +17,9 @@
 use function explode;
 use function sprintf;
 
+/**
+ * @implements Rule<InClassMethodNode>
+ */
 final class SymfonyCmfRoutingInClassMethodSignatureRule implements Rule
 {
 
@@ -27,7 +30,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof InClassMethodNode);
         if (DeprecatedScopeCheck::inDeprecatedScope($scope)) {
             return [];
         }

src/Rules/Drupal/Coder/DiscouragedFunctionsRule.php

@@ -12,6 +12,8 @@
 
 /**
  * Based on Drupal_Sniffs_Functions_DiscouragedFunctionsSniff.
+ *
+ * @implements Rule<FuncCall>
  */
 class DiscouragedFunctionsRule implements Rule
 {
@@ -22,8 +24,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof FuncCall);
-
         if (!($node->name instanceof Node\Name)) {
             return [];
         }