Fix autoloading of test base classes (#60)

* Run analyse against dynamic_page_cache

* Tests should test Test.php, fix autoloading

* Adjust test namespacing registration

* Specify check to fail if autoloading message exists

Author: mglaman

.travis.yml

@@ -23,6 +23,8 @@ script:
 
   # Test that a known non-failing file doesn't error out.
   - ./vendor/bin/phpstan analyze web/core/install.php --debug
+  - ./vendor/bin/phpstan analyze web/core/modules/dynamic_page_cache  | grep -q "Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded." && false || true
+
   # Verify test fixtures are ignored.
   - ./vendor/bin/phpstan analyze web/core/modules/migrate_drupal --no-progress | grep -q "tests/fixtures" && false || true
 

src/Drupal/Bootstrap.php

@@ -145,12 +145,12 @@ protected function addCoreNamespaces(): void
         }
 
         // Add core test namespaces.
-        $core_tests_dir = $this->drupalRoot . '/core/tests';
-        $this->autoloader->add('Drupal\\Tests', $core_tests_dir);
-        $this->autoloader->add('Drupal\\TestSite', $core_tests_dir);
-        $this->autoloader->add('Drupal\\KernelTests', $core_tests_dir);
-        $this->autoloader->add('Drupal\\FunctionalTests', $core_tests_dir);
-        $this->autoloader->add('Drupal\\FunctionalJavascriptTests', $core_tests_dir);
+        $core_tests_dir = $this->drupalRoot . '/core/tests/Drupal';
+        $this->namespaces['Drupal\\Tests'] = $core_tests_dir . '/Tests';
+        $this->namespaces['Drupal\\TestSite'] = $core_tests_dir . '/TestSite';
+        $this->namespaces['Drupal\\KernelTests'] = $core_tests_dir . '/KernelTests';
+        $this->namespaces['Drupal\\FunctionalTests'] =  $core_tests_dir . '/FunctionalTests';
+        $this->namespaces['Drupal\\FunctionalJavascriptTests'] = $core_tests_dir . '/FunctionalJavascriptTests';
     }
     protected function addModuleNamespaces(): void
     {

tests/fixtures/config/drupal-phpstan.neon

@@ -1,7 +1,4 @@
 parameters:
-	excludes_analyse:
-		- *Test.php
-		- *TestBase.php
 	level: 0
 includes:
 	- vendor/mglaman/phpstan-drupal/extension.neon

tests/fixtures/config/phpunit-drupal-phpstan.neon

@@ -1,7 +1,4 @@
 parameters:
-	excludes_analyse:
-		- *Test.php
-		- *TestBase.php
 	level: 7
 drupal:
 	drupal_root: %currentWorkingDirectory%