properly set static type in constant array for callable

Author: mglaman

composer.json

@@ -46,7 +46,8 @@
             "mglaman\\PHPStanDrupal\\Tests\\": "tests/src/"
         },
         "classmap": [
-            "tests/src/Type/data"
+            "tests/src/Type/data",
+            "tests/src/Rules/data"
         ]
     },
     "extra": {

src/Rules/Drupal/RenderCallbackRule.php

@@ -150,6 +150,12 @@ private function doProcessNode(Node\Expr $node, Scope $scope, string $keyChecked
                     ->tip('Change record: https://www.drupal.org/node/2966725.')
                     ->build();
             }
+
+            if (!$trustedCallbackType->isSuperTypeOf($type)->yes()) {
+                return RuleErrorBuilder::message(
+                    sprintf("%s callback class %s at key '%s' does not implement Drupal\Core\Security\TrustedCallbackInterface.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
+                )->line($errorLine)->tip('Change record: https://www.drupal.org/node/2966725.')->build();
+            }
         } elseif ($type instanceof ConstantArrayType) {
             if (!$type->isCallable()->yes()) {
                 return RuleErrorBuilder::message(
@@ -204,8 +210,14 @@ private function getType(Node\Expr $node, Scope $scope):  Type
             if ($node instanceof Node\Expr\BinaryOp\Concat) {
                 $leftType = $scope->getType($node->left);
                 $rightType = $scope->getType($node->right);
-                if ($leftType instanceof GenericClassStringType && $leftType->getGenericType() instanceof StaticType && $rightType instanceof ConstantStringType) {
-                    return new ConstantStringType($leftType->getGenericType()->getClassName() . $rightType->getValue());
+                if ($rightType instanceof ConstantStringType && $leftType instanceof GenericClassStringType && $leftType->getGenericType() instanceof StaticType) {
+                    return new ConstantArrayType(
+                        [new ConstantIntegerType(0), new ConstantIntegerType(1)],
+                        [
+                            $leftType->getGenericType(),
+                            new ConstantStringType(ltrim($rightType->getValue(), ':'))
+                        ]
+                    );
                 }
             }
         } elseif ($type instanceof ConstantStringType) {
@@ -234,7 +246,7 @@ private function getType(Node\Expr $node, Scope $scope):  Type
                 return new ConstantArrayType(
                     [new ConstantIntegerType(0), new ConstantIntegerType(1)],
                     [
-                        new ConstantStringType($matches[1], true),
+                        new StaticType($this->reflectionProvider->getClass($matches[1])),
                         new ConstantStringType($matches[2])
                     ]
                 );

tests/src/Rules/RenderCallbackRuleTest.php

@@ -52,7 +52,7 @@ public function fileData(): \Generator
                     'Change record: https://www.drupal.org/node/2966725.',
                 ],
                 [
-                    "#pre_render callback class 'Drupal\pre_render_callback_rule\NotTrustedCallback' at key '3' does not implement Drupal\Core\Security\TrustedCallbackInterface.",
+                    "#pre_render callback class 'static(Drupal\pre_render_callback_rule\NotTrustedCallback)' at key '3' does not implement Drupal\Core\Security\TrustedCallbackInterface.",
                     29,
                     'Change record: https://www.drupal.org/node/2966725.',
                 ],
@@ -100,8 +100,9 @@ public function fileData(): \Generator
             __DIR__ . '/data/bug-424.php',
             [
                 [
-                    "#lazy_builder callback 'Bug424\\\Foo:…' at key '0' is not callable.",
+                    "#lazy_builder callback class 'static(Bug424\Foo)' at key '0' does not implement Drupal\Core\Security\TrustedCallbackInterface.",
                     10,
+                    "Change record: https://www.drupal.org/node/2966725."
                 ],
                 [
                     "#lazy_builder callback class 'static(Bug424\Foo)' at key '0' does not implement Drupal\Core\Security\TrustedCallbackInterface.",