Merge pull request #231 from mglaman/defaultthemerule-testing-only

Only error on defaultTheme for testing profiles

Author: mglaman

src/Rules/Drupal/Tests/BrowserTestBaseDefaultThemeRule.php

@@ -39,6 +39,21 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
         $defaultProperties = $reflection->getNativeReflection()->getDefaultProperties();
+        $profile = $defaultProperties['profile'] ?? null;
+
+        $testingProfilesWithoutThemes = [
+            'testing',
+            'nightwatch_testing',
+            'testing_config_overrides',
+            'testing_missing_dependencies',
+            'testing_multilingual',
+            'testing_multilingual_with_english',
+            'testing_requirements',
+        ];
+        if ($profile !== null && !in_array($profile, $testingProfilesWithoutThemes, true)) {
+            return [];
+        }
+
         $defaultTheme = $defaultProperties['defaultTheme'] ?? null;
 
         if ($defaultTheme === null || $defaultTheme === '') {

tests/src/Rules/BrowserTestBaseDefaultThemeRuleTest.php

@@ -41,6 +41,10 @@ public function fileData(): \Generator
             __DIR__ . '/../../fixtures/drupal/modules/module_with_tests/tests/src/Functional/DefaultThemeTest.php',
             []
         ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/tests/Drupal/FunctionalTests/Installer/InstallerExistingConfigMultilingualTest.php',
+            []
+        ];
         yield [
             __DIR__ . '/../../fixtures/drupal/modules/module_with_tests/tests/src/Functional/ExtendsDefaultThemeTest.php',
             []