Merge pull request #29 from mglaman/test-with-drupal

Attempt to add basic integration testing

Author: mglaman

.travis.yml

@@ -7,13 +7,25 @@ php:
 before_script:
   - if php --ri xdebug >/dev/null; then phpenv config-rm xdebug.ini; fi
 before_install:
-  - composer self-update
   - composer global require "hirak/prestissimo:^0.3"
 install:
   - composer install --no-interaction
 script:
+  # Inspections
   - ./vendor/bin/phpcs src
   - ./vendor/bin/phpstan analyze src
+
+  # Try to add to a Drupal setup.
+  - composer create-project drupal-composer/drupal-project:8.x-dev $TRAVIS_BUILD_DIR/../drupal --no-interaction
+  - cd $TRAVIS_BUILD_DIR/../drupal
+
+  # Install dependency.
+  - composer config repositories.0 path $TRAVIS_BUILD_DIR
+  - cat composer.json
+  - composer require mglaman/phpstan-drupal *@dev
+  - cp $TRAVIS_BUILD_DIR/tests/fixtures/drupal-phpstan.neon phpstan.neon
+  - ./vendor/bin/phpstan analyze web/core/install.php
+
 cache:
   directories:
     - $HOME/.composer/cache

src/DependencyInjection/DrupalExtension.php

@@ -120,8 +120,13 @@ public function loadConfiguration(): void
                 // Prevent \Nette\DI\ContainerBuilder::completeStatement from array_walk_recursive into the arguments
                 // and thinking these are real services for PHPStan's container.
                 if (isset($serviceDefinition['arguments']) && is_array($serviceDefinition['arguments'])) {
-                    array_walk($serviceDefinition['arguments'], function (string &$argument) : void {
-                        $argument = str_replace('@', '', $argument);
+                    array_walk($serviceDefinition['arguments'], function (&$argument) : void {
+                        if (is_array($argument)) {
+                            // @todo fix for @http_kernel.controller.argument_metadata_factory
+                            $argument = '';
+                        } else {
+                            $argument = str_replace('@', '', $argument);
+                        }
                     });
                 }
                 unset($serviceDefinition['tags']);

tests/fixtures/drupal-phpstan.neon

@@ -0,0 +1,7 @@
+parameters:
+	excludes_analyse:
+		- *Test.php
+		- *TestBase.php
+	level: 0
+includes:
+	- vendor/mglaman/phpstan-drupal/extension.neon