Ignore accessCheck on config entity queries (#517)

Author: mglaman

src/Rules/Drupal/EntityQuery/EntityQueryHasAccessCheckRule.php

@@ -4,6 +4,7 @@
 
 namespace mglaman\PHPStanDrupal\Rules\Drupal\EntityQuery;
 
+use mglaman\PHPStanDrupal\Type\EntityQuery\ConfigEntityQueryType;
 use mglaman\PHPStanDrupal\Type\EntityQuery\EntityQueryExecuteWithoutAccessCheckCountType;
 use mglaman\PHPStanDrupal\Type\EntityQuery\EntityQueryExecuteWithoutAccessCheckType;
 use PhpParser\Node;
@@ -38,6 +39,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        $parent = $scope->getType($node->var);
+        if ($parent instanceof ConfigEntityQueryType) {
+            return [];
+        }
+
         return [
             RuleErrorBuilder::message(
                 'Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.'

tests/src/Rules/EntityQueryHasAccessCheckRuleTest.php

@@ -132,5 +132,10 @@ public function cases(): \Generator
             [__DIR__.'/data/bug-496.php'],
             []
         ];
+
+        yield 'bug-479.php' => [
+            [__DIR__.'/data/bug-479.php'],
+            []
+        ];
     }
 }

tests/src/Rules/data/bug-479.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Bug479Example;
+
+class TestClass {
+
+    /**
+     * Tests non-chained entity queries with access check.
+     */
+    public function bug479(string $entity_type): void
+    {
+        $query = \Drupal::entityQuery('entity_form_display');
+        $query->execute();
+    }
+}