Merge pull request #426 from mglaman/gh424

Test #lazy_builder and static::class concat for callback

Author: mglaman

tests/src/Rules/RenderCallbackRuleTest.php

@@ -108,6 +108,21 @@ public function fileData(): \Generator
             __DIR__ . '/../../fixtures/drupal/core/lib/Drupal/Core/Render/Renderer.php',
             []
         ];
+        yield [
+            __DIR__ . '/data/bug-424.php',
+            [
+                [
+                    "#lazy_builder value 'non-empty-string' at key '0' is invalid.",
+                    10,
+                    "Refactor concatenation of `static::class` with method name to an array callback: [static::class, 'contentLazyBuilder']"
+                ],
+                [
+                    "#lazy_builder callback class 'static(Bug424\Foo)' at key '0' does not implement Drupal\Core\Security\TrustedCallbackInterface.",
+                    17,
+                    "Change record: https://www.drupal.org/node/2966725."
+                ]
+            ]
+        ];
     }
 
 

tests/src/Rules/data/bug-424.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Bug424;
+
+class Foo {
+    public function render(): array {
+        $build = [
+            'one' => [
+                '#lazy_builder' => [
+                    static::class . '::contentLazyBuilder',
+                    ['foo'],
+                ],
+                '#create_placeholder' => TRUE,
+            ],
+            'two' => [
+                '#lazy_builder' => [
+                    [static::class, 'contentLazyBuilder'],
+                    ['foo'],
+                ],
+                '#create_placeholder' => TRUE,
+            ]
+        ];
+
+        return $build;
+    }
+
+    public static function contentLazyBuilder(string $foo): void {
+
+    }
+}