Fix phpstan inspection failures

Author: mglaman

src/Rules/Drupal/LoadIncludes.php

@@ -73,14 +73,17 @@ public function processNode(Node $node, Scope $scope): array
             $extensionDiscovery = new ExtensionDiscovery($drupal_root);
             $modules = $extensionDiscovery->scan('module');
             $module_arg = $node->args[0];
+            assert($module_arg instanceof Node\Arg);
             assert($module_arg->value instanceof Node\Scalar\String_);
             $type_arg = $node->args[1];
+            assert($type_arg instanceof Node\Arg);
             assert($type_arg->value instanceof Node\Scalar\String_);
             $name_arg = $node->args[2] ?? null;
 
             if ($name_arg === null) {
                 $name_arg = $module_arg;
             }
+            assert($name_arg instanceof Node\Arg);
             assert($name_arg->value instanceof Node\Scalar\String_);
 
             $module_name = $module_arg->value->value;

src/Rules/Drupal/ModuleLoadInclude.php

@@ -48,7 +48,6 @@ public function processNode(Node $node, Scope $scope): array
         if ($name !== 'module_load_include') {
             return [];
         }
-        $stop = null;
 
         try {
             // Try to invoke it similarily as the module handler itself.
@@ -58,14 +57,17 @@ public function processNode(Node $node, Scope $scope): array
             $extensionDiscovery = new ExtensionDiscovery($drupal_root);
             $modules = $extensionDiscovery->scan('module');
             $type_arg = $node->args[0];
+            assert($type_arg instanceof Node\Arg);
             assert($type_arg->value instanceof Node\Scalar\String_);
             $module_arg = $node->args[1];
+            assert($module_arg instanceof Node\Arg);
             assert($module_arg->value instanceof Node\Scalar\String_);
             $name_arg = $node->args[2] ?? null;
 
             if ($name_arg === null) {
                 $name_arg = $module_arg;
             }
+            assert($name_arg instanceof Node\Arg);
             assert($name_arg->value instanceof Node\Scalar\String_);
 
             $module_name = $module_arg->value->value;

src/Rules/Drupal/PluginManager/PluginManagerSetsCacheBackendRule.php

@@ -61,13 +61,19 @@ public function processNode(Node $node, Scope $scope): array
                 // setCacheBackend accepts a cache backend, the cache key, and optional (but suggested) cache tags.
                 $setCacheBackendArgs = $statement->args;
 
+                if ($setCacheBackendArgs[1] instanceof Node\VariadicPlaceholder) {
+                    throw new ShouldNotHappenException();
+                }
                 $cacheKey = $setCacheBackendArgs[1]->value;
                 if (!$cacheKey instanceof Node\Scalar\String_) {
                     continue;
                 }
                 $hasCacheBackendSet = true;
 
                 if (isset($setCacheBackendArgs[2])) {
+                    if ($setCacheBackendArgs[2] instanceof Node\VariadicPlaceholder) {
+                        throw new ShouldNotHappenException();
+                    }
                     /** @var \PhpParser\Node\Expr\Array_ $cacheTags */
                     $cacheTags = $setCacheBackendArgs[2]->value;
                     if (count($cacheTags->items) > 0) {

src/Type/EntityTypeManagerGetStorageDynamicReturnTypeExtension.php

@@ -5,6 +5,7 @@
 use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Scalar\String_;
+use PhpParser\Node\VariadicPlaceholder;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
@@ -48,7 +49,11 @@ public function getTypeFromMethodCall(
             throw new ShouldNotHappenException();
         }
 
-        $arg1 = $methodCall->args[0]->value;
+        $arg1 = $methodCall->args[0];
+        if ($arg1 instanceof VariadicPlaceholder) {
+            throw new ShouldNotHappenException();
+        }
+        $arg1 = $arg1->value;
 
         // @todo handle where the first param is EntityTypeInterface::id()
         if ($arg1 instanceof MethodCall) {

src/Type/ServiceDynamicReturnTypeExtension.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Scalar\String_;
+use PhpParser\Node\VariadicPlaceholder;
 use PHPStan\Analyser\Scope;
 use PHPStan\Drupal\DrupalServiceDefinition;
 use PHPStan\Drupal\ServiceMap;
@@ -45,7 +46,11 @@ public function getTypeFromMethodCall(
             return $returnType;
         }
 
-        $arg1 = $methodCall->args[0]->value;
+        $arg1 = $methodCall->args[0];
+        if ($arg1 instanceof VariadicPlaceholder) {
+            throw new ShouldNotHappenException();
+        }
+        $arg1 = $arg1->value;
         if (!$arg1 instanceof String_) {
             // @todo determine what these types are.
             return $returnType;