Use objectType instead

Author: eiriksm

src/Reflection/EntityFieldsViaMagicReflectionExtension.php

@@ -5,6 +5,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\PropertiesClassReflectionExtension;
 use PHPStan\Reflection\PropertyReflection;
+use PHPStan\Type\ObjectType;
 
 /**
  * Allows field access via magic methods
@@ -32,7 +33,7 @@ public function hasProperty(ClassReflection $classReflection, string $propertyNa
             // Content entities have magical __get... so it is kind of true.
             return true;
         }
-        if ($reflection->getName() === 'Drupal\Core\Field\FieldItemListInterface' || $reflection->implementsInterface('Drupal\Core\Field\FieldItemListInterface')) {
+        if (self::classObjectIsSuperOfFieldItemList($reflection)) {
             return FieldItemListPropertyReflection::canHandleProperty($classReflection, $propertyName);
         }
 
@@ -45,10 +46,22 @@ public function getProperty(ClassReflection $classReflection, string $propertyNa
         if ($reflection->implementsInterface('Drupal\Core\Entity\EntityInterface')) {
             return new EntityFieldReflection($classReflection, $propertyName);
         }
-        if ($reflection->getName() === 'Drupal\Core\Field\FieldItemListInterface' || $reflection->implementsInterface('Drupal\Core\Field\FieldItemListInterface')) {
+        if (self::classObjectIsSuperOfFieldItemList($reflection)) {
             return new FieldItemListPropertyReflection($classReflection, $propertyName);
         }
 
         throw new \LogicException($classReflection->getName() . "::$propertyName should be handled earlier.");
     }
+
+    protected static function classObjectIsSuperOfFieldItemList(\ReflectionClass $reflection)
+    {
+        $classObject = new ObjectType($reflection->getName());
+        $interfaceObject = self::getFieldItemListInterfaceObject();
+        return $classObject->isSuperTypeOf($interfaceObject);
+    }
+
+    protected static function getFieldItemListInterfaceObject()
+    {
+        return new ObjectType('Drupal\Core\Field\FieldItemListInterface');
+    }
 }