Handle concatenation of static::class with string as callback

Author: mglaman

src/Rules/Drupal/RenderCallbackRule.php

@@ -12,6 +12,8 @@
 use PHPStan\Type\Constant\ConstantArrayType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Constant\ConstantStringType;
+use PHPStan\Type\Generic\GenericClassStringType;
+use PHPStan\Type\IntersectionType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
@@ -120,10 +122,30 @@ public function processNode(Node $node, Scope $scope): array
                         )->line($errorLine)->build();
                     }
                 }
-            } else {
+            } elseif ($type instanceof IntersectionType) {
+                // Try to provide a tip for this weird occurrence.
+                $tip = '';
+                if ($item->value instanceof Node\Expr\BinaryOp\Concat) {
+                    $leftStringType = $scope->getType($item->value->left)->toString();
+                    $rightStringType = $scope->getType($item->value->right)->toString();
+                    if ($leftStringType instanceof GenericClassStringType && $rightStringType instanceof ConstantStringType) {
+                        $methodName = str_replace(':', '', $rightStringType->getValue());
+                        $tip = "Refactor concatenation of `static::class` with method name to an array callback: [static::class, '$methodName']";
+                    }
+                }
+
+                if ($tip === '') {
+                    $tip = 'If this error is unexpected, open an issue with the error and sample code https://github.com/mglaman/phpstan-drupal/issues/new';
+                }
+
+                $errors[] = RuleErrorBuilder::message(
+                    sprintf("%s value '%s' at key '%s' is invalid.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
+                )->line($errorLine)->tip($tip)->build();
+            }else {
                 $errors[] = RuleErrorBuilder::message(
                     sprintf("%s value '%s' at key '%s' is invalid.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
-                )->line($errorLine)->build();
+                )->line($errorLine)->tip('Open an issue https://github.com/mglaman/phpstan-drupal/issues/new with this error.')
+                    ->build();
             }
         }
 

tests/fixtures/drupal/modules/pre_render_callback_rule/src/LazyBuilderWithConstant.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types=1);
+
+namespace Drupal\pre_render_callback_rule;
+
+use Drupal\Core\Security\TrustedCallbackInterface;
+use Drupal\Core\Url;
+
+class LazyBuilderWithConstant implements TrustedCallbackInterface {
+
+    public function staticCallback(): array {
+        return [
+            '#lazy_builder' => [
+                [[self::class, 'lazyBuilder'], ['baz', true]],
+                [[static::class, 'lazyBuilder'], ['mars', false]],
+                [[$this, 'lazyBuilder'], ['mars', false]],
+                [self::class . '::lazyBuilder', ['baz', true]],
+                [static::class . '::lazyBuilder', ['mars', false]],
+            ]
+        ];
+    }
+
+    public static function lazyBuilder(string $foo, bool $bar) {
+        return [
+            '#markup' => "$foo $bar",
+        ];
+    }
+
+    public static function trustedCallbacks()
+    {
+        return ['lazyBuilder'];
+    }
+}

tests/fixtures/drupal/modules/pre_render_callback_rule/src/RenderArrayWithPreRenderCallback.php

@@ -5,7 +5,7 @@
 use Drupal\Core\Security\TrustedCallbackInterface;
 use Drupal\Core\Url;
 
-final class RenderArrayWithPreRenderCallback implements TrustedCallbackInterface {
+class RenderArrayWithPreRenderCallback implements TrustedCallbackInterface {
 
     public function staticCallback(): array {
         return [
@@ -14,6 +14,9 @@ public function staticCallback(): array {
             '#title' => 'FooBar',
             '#pre_render' => [
                 [self::class, 'preRenderCallback'],
+                [static::class, 'preRenderCallback'],
+                self::class . '::preRenderCallback',
+                static::class . '::preRenderCallback',
                 [$this, 'preRenderCallback'],
                 static function(array $element): array {
                     return $element;

tests/src/Rules/PreRenderCallbackRuleTest.php

@@ -65,7 +65,13 @@ public function fileData(): \Generator
         ];
         yield [
             __DIR__ . '/../../fixtures/drupal/modules/pre_render_callback_rule/src/RenderArrayWithPreRenderCallback.php',
-            []
+            [
+                [
+                    "#pre_render value 'non-empty-string' at key '3' is invalid.",
+                    19,
+                    "Refactor concatenation of `static::class` with method name to an array callback: [static::class, 'preRenderCallback']"
+                ]
+            ]
         ];
         yield [
             __DIR__ . '/../../fixtures/drupal/modules/pre_render_callback_rule/src/RenderCallbackInterfaceObject.php',