Fix null check on lazy_builder callback

mglaman · mglaman · commit 6d3cd40dfd85 · 2022-01-12T16:13:39.000-06:00
diff --git a/src/Rules/Drupal/RenderCallbackRule.php b/src/Rules/Drupal/RenderCallbackRule.php
@@ -83,7 +83,7 @@ public function processNode(Node $node, Scope $scope): array
                     continue;
                 }
 
-                if (count($item->value->items) !== 2) {
+                if (count($item->value->items) !== 2 || $item->value->items[0] === null) {
                     $errors[] = RuleErrorBuilder::message(
                         sprintf("%s callback %s at key '%s' is not valid. First value must be a callback and second value its arguments.", $keyChecked, $scope->getType($item->value)->describe(VerbosityLevel::value()), $pos)
                     )->line($item->value->getLine())->build();

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public function processNode(Node $node, Scope $scope): array`
`83`	`83`	`continue;`
`84`	`84`	`}`
`85`	`85`
`86`		`- if (count($item->value->items) !== 2) {`
	`86`	`+ if (count($item->value->items) !== 2 \|\| $item->value->items[0] === null) {`
`87`	`87`	`$errors[] = RuleErrorBuilder::message(`
`88`	`88`	`sprintf("%s callback %s at key '%s' is not valid. First value must be a callback and second value its arguments.", $keyChecked, $scope->getType($item->value)->describe(VerbosityLevel::value()), $pos)`
`89`	`89`	`)->line($item->value->getLine())->build();`