Fix RenderCallbackRule PHPStan errors (#710)

mglaman · web-flow · commit 6e6f455133d0 · 2024-01-10T10:35:24.000-06:00
diff --git a/src/Rules/Drupal/RenderCallbackRule.php b/src/Rules/Drupal/RenderCallbackRule.php
@@ -102,9 +102,6 @@ public function processNode(Node $node, Scope $scope): array
             if (count($value->items) === 0) {
                 return [];
             }
-            if ($value->items[0] === null) {
-                return [];
-            }
             // @todo take $value->items[1] and validate parameters against the callback.
             return $this->doProcessNode($value->items[0]->value, $scope, $keyChecked, 0);
         }
@@ -120,9 +117,6 @@ public function processNode(Node $node, Scope $scope): array
         }
         $errors = [];
         foreach ($value->items as $pos => $item) {
-            if (!$item instanceof Node\Expr\ArrayItem) {
-                continue;
-            }
             $errors[] = $this->doProcessNode($item->value, $scope, $keyChecked, $pos);
         }
         return array_merge(...$errors);

Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,6 @@ public function processNode(Node $node, Scope $scope): array`
`102`	`102`	`if (count($value->items) === 0) {`
`103`	`103`	`return [];`
`104`	`104`	`}`
`105`		`- if ($value->items[0] === null) {`
`106`		`- return [];`
`107`		`- }`
`108`	`105`	`// @todo take $value->items[1] and validate parameters against the callback.`
`109`	`106`	`return $this->doProcessNode($value->items[0]->value, $scope, $keyChecked, 0);`
`110`	`107`	`}`
`@@ -120,9 +117,6 @@ public function processNode(Node $node, Scope $scope): array`
`120`	`117`	`}`
`121`	`118`	`$errors = [];`
`122`	`119`	`foreach ($value->items as $pos => $item) {`
`123`		`- if (!$item instanceof Node\Expr\ArrayItem) {`
`124`		`- continue;`
`125`		`- }`
`126`	`120`	`$errors[] = $this->doProcessNode($item->value, $scope, $keyChecked, $pos);`
`127`	`121`	`}`
`128`	`122`	`return array_merge(...$errors);`