Stricter check in RenderCallbackRule for $matches (#831)

mglaman · mglaman · commit 727887de0fbe · 2025-03-27T10:24:55.000-04:00
(cherry picked from commit a461737)
diff --git a/src/Rules/Drupal/RenderCallbackRule.php b/src/Rules/Drupal/RenderCallbackRule.php
@@ -302,7 +302,7 @@ private function getType(Node\Expr $node, Scope $scope):  Type
             }
             // @see \PHPStan\Type\Constant\ConstantStringType::isCallable
             preg_match('#^([a-zA-Z_\\x7f-\\xff\\\\][a-zA-Z0-9_\\x7f-\\xff\\\\]*)::([a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]*)\\z#', $type->getValue(), $matches);
-            if (count($matches) > 0) {
+            if (count($matches) === 3) {
                 return new ConstantArrayType(
                     [new ConstantIntegerType(0), new ConstantIntegerType(1)],
                     [

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ private function getType(Node\Expr $node, Scope $scope): Type`
`302`	`302`	`}`
`303`	`303`	`// @see \PHPStan\Type\Constant\ConstantStringType::isCallable`
`304`	`304`	`preg_match('#^([a-zA-Z_\\x7f-\\xff\\\\][a-zA-Z0-9_\\x7f-\\xff\\\\])::([a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff])\\z#', $type->getValue(), $matches);`
`305`		`- if (count($matches) > 0) {`
	`305`	`+ if (count($matches) === 3) {`
`306`	`306`	`return new ConstantArrayType(`
`307`	`307`	`[new ConstantIntegerType(0), new ConstantIntegerType(1)],`
`308`	`308`	`[`