Improve RevisionableStorageInterface stub (#596)

* Improve RevisionableStorageInterface stub

* Fix when inferred as ContentEntityStorageBase

* caching and ordering is silly

* document madness

* fix union types

* track actual error

* error is 10.1.0+

Author: mglaman

phpstan.neon

@@ -8,6 +8,7 @@ parameters:
 		- drupal-autoloader.php
 		- tests/src
 	excludePaths:
+		-  tests/src/data/*.php
 		-  tests/src/Type/data/*.php
 		-  tests/src/Rules/data/*.php
 	dynamicConstantNames:

stubs/Drupal/Core/Entity/BundleEntityStorageInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+interface BundleEntityStorageInterface {
+
+}

stubs/Drupal/Core/Entity/ContentEntityStorageBase.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+abstract class ContentEntityStorageBase extends EntityStorageBase implements ContentEntityStorageInterface, DynamicallyFieldableEntityStorageInterface, BundleEntityStorageInterface {
+
+}

stubs/Drupal/Core/Entity/ContentEntityStorageInterface.stub

@@ -0,0 +1,9 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+// Remove extension of `EntityStorageInterface` so that `TranslatableRevisionableStorageInterface`
+// is properly processed.
+interface ContentEntityStorageInterface extends TranslatableRevisionableStorageInterface {
+
+}

stubs/Drupal/Core/Entity/DynamicallyFieldableEntityStorageInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+interface DynamicallyFieldableEntityStorageInterface extends FieldableEntityStorageInterface, FieldStorageDefinitionListenerInterface, FieldDefinitionListenerInterface {
+
+}

stubs/Drupal/Core/Entity/EntityHandlerBase.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+abstract class EntityHandlerBase {
+
+}

stubs/Drupal/Core/Entity/EntityHandlerInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+interface EntityHandlerInterface {
+
+}

stubs/Drupal/Core/Entity/EntityStorageBase.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+abstract class EntityStorageBase extends EntityHandlerBase implements EntityStorageInterface, EntityHandlerInterface {
+
+}

stubs/Drupal/Core/Entity/FieldableEntityStorageInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Entity;
+
+
+interface FieldableEntityStorageInterface extends EntityStorageInterface {
+}

stubs/Drupal/Core/Entity/RevisionableStorageInterface.stub

@@ -7,13 +7,11 @@ interface RevisionableStorageInterface extends EntityStorageInterface {
   /**
    * @param int|numeric-string $revision_id
    * @return \Drupal\Core\Entity\RevisionableInterface|null
-   * @not-deprecated
    */
   public function loadRevision($revision_id);
 
   /**
    * @param int|numeric-string $revision_id
-   * @not-deprecated
    */
   public function deleteRevision($revision_id): void;