RenderCallbackRule should use ObjectType for service class instance (#582)

Author: mglaman

src/Rules/Drupal/RenderCallbackRule.php

@@ -280,7 +280,7 @@ private function getType(Node\Expr $node, Scope $scope):  Type
             if ($type->isClassStringType()->yes()) {
                 return $type;
             }
-            // Covers  \Drupal\Core\Controller\ControllerResolver::createController.
+            // Covers \Drupal\Core\Controller\ControllerResolver::createController.
             if (substr_count($type->getValue(), ':') === 1) {
                 [$class_or_service, $method] = explode(':', $type->getValue(), 2);
 
@@ -291,7 +291,7 @@ private function getType(Node\Expr $node, Scope $scope):  Type
                 return new ConstantArrayType(
                     [new ConstantIntegerType(0), new ConstantIntegerType(1)],
                     [
-                        new ConstantStringType($serviceDefinition->getClass(), true),
+                        new ObjectType($serviceDefinition->getClass()),
                         new ConstantStringType($method)
                     ]
                 );

src/Rules/Drupal/Tests/BrowserTestBaseDefaultThemeRule.php

@@ -38,7 +38,8 @@ public function processNode(Node $node, Scope $scope): array
 
         // Do some cheap preflight tests to make sure the class is in a
         // namespace that makes sense to inspect.
-        $parts = $node->namespacedName->parts;
+        // @phpstan-ignore-next-line
+        $parts = method_exists($node->namespacedName, 'getParts') ? $node->namespacedName->getParts() : $node->namespacedName->parts;
         // The namespace is too short to be a test so skip inspection.
         if (count($parts) < 3) {
             return [];