Allow static::class . '::methodName' concatenation in lazy builders.

Author: longwave

src/Rules/Drupal/RenderCallbackRule.php

@@ -19,6 +19,7 @@
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\StaticType;
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
@@ -185,25 +186,6 @@ private function doProcessNode(Node\Expr $node, Scope $scope, string $keyChecked
                     sprintf("%s callback %s at key '%s' is not callable.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
                 )->line($errorLine)->build();
             }
-        } elseif ($type instanceof IntersectionType) {
-            // Try to provide a tip for this weird occurrence.
-            $tip = '';
-            if ($node instanceof Node\Expr\BinaryOp\Concat) {
-                $leftStringType = $scope->getType($node->left)->toString();
-                $rightStringType = $scope->getType($node->right)->toString();
-                if ($leftStringType instanceof GenericClassStringType && $rightStringType instanceof ConstantStringType) {
-                    $methodName = str_replace(':', '', $rightStringType->getValue());
-                    $tip = "Refactor concatenation of `static::class` with method name to an array callback: [static::class, '$methodName']";
-                }
-            }
-
-            if ($tip === '') {
-                $tip = 'If this error is unexpected, open an issue with the error and sample code https://github.com/mglaman/phpstan-drupal/issues/new';
-            }
-
-            return RuleErrorBuilder::message(
-                sprintf("%s value '%s' at key '%s' is invalid.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
-            )->line($errorLine)->tip($tip)->build();
         } else {
             return RuleErrorBuilder::message(
                 sprintf("%s value '%s' at key '%s' is invalid.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
@@ -217,7 +199,16 @@ private function doProcessNode(Node\Expr $node, Scope $scope, string $keyChecked
     private function getType(Node\Expr $node, Scope $scope):  Type
     {
         $type = $scope->getType($node);
-        if ($type instanceof ConstantStringType) {
+        if ($type instanceof IntersectionType) {
+            // Covers concatenation of static::class . '::methodName'.
+            if ($node instanceof Node\Expr\BinaryOp\Concat) {
+                $leftType = $scope->getType($node->left);
+                $rightType = $scope->getType($node->right);
+                if ($leftType instanceof GenericClassStringType && $leftType->getGenericType() instanceof StaticType && $rightType instanceof ConstantStringType) {
+                    return new ConstantStringType($leftType->getGenericType()->getClassName() . $rightType->getValue());
+                }
+            }
+        } elseif ($type instanceof ConstantStringType) {
             if ($type->isClassString()) {
                 return $type;
             }