Ensure configlevel2 runs, verify service map broken

Author: mglaman

tests/fixtures/config/phpunit-drupal-phpstan.neon

@@ -4,6 +4,7 @@ parameters:
 	# Ignore functions for the PHPUnit bootstrap process.
 	ignoreErrors:
 		- '#Function drupal_phpunit_[a-zA-Z0-9\\_]+ not found#'
+		- '#Unsafe usage of new static().#'
 	drupal:
 		drupal_root: %currentWorkingDirectory%
 includes:

tests/fixtures/drupal/modules/phpstan_fixtures/phpstan_fixtures.module

@@ -1,7 +1,13 @@
 <?php
 
-function phpstan_fixtures_included() {
+// Catches at level 4.
+function phpstan_fixtures_IfConstantConditionRule() {
     $zero = 0;
     if ($zero) {
     }
 }
+
+// Catches at level 0.
+function phpstan_fixtures_MissingReturnRule(): string {
+
+}

tests/fixtures/drupal/modules/phpstan_fixtures/src/UsesDeprecatedServiceMethod.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Drupal\phpstan_fixtures;
+
+use Drupal\Core\Entity\EntityManager;
+
+class UsesDeprecatedServiceMethod {
+    public function test() {
+        $entity_manager = \Drupal::getContainer()->get('entity.manager');
+        // Deprecated for EntityTypeManagerInterface::getDefinitions().
+        $definitions = $entity_manager->getDefinitions();
+    }
+}

tests/src/AnalyzerTestBase.php

@@ -14,11 +14,12 @@ protected function runAnalyze(string $path) {
         $rootDir = __DIR__ . '/../fixtures/drupal';
         $tmpDir = sys_get_temp_dir() . '/' . time() . 'phpstan';
         $containerFactory = new ContainerFactory($rootDir);
-        $container = $containerFactory->create(
-            $tmpDir,
-            [__DIR__ . '/../fixtures/config/phpunit-drupal-phpstan.neon'],
-            []
-        );
+
+        $additionalConfigFiles = [
+            \sprintf('%s/config.level%s.neon', $containerFactory->getConfigDirectory(), 2),
+            __DIR__ . '/../fixtures/config/phpunit-drupal-phpstan.neon',
+        ];
+        $container = $containerFactory->create($tmpDir, $additionalConfigFiles, []);
         $fileHelper = $container->getByType(FileHelper::class);
         assert($fileHelper !== null);
 

tests/src/DeprecationRulesTest.php

@@ -32,10 +32,11 @@ public function dataDeprecatedSamples(): \Generator
         ];
         yield [
             __DIR__ . '/../fixtures/drupal/core/lib/Drupal/Core/Entity/EntityManager.php',
-            1,
+            2,
             [
                 'Class Drupal\Core\Entity\EntityManager implements deprecated interface Drupal\Core\Entity\EntityManagerInterface:
-in drupal:8.0.0 and is removed from drupal:9.0.0.'
+in drupal:8.0.0 and is removed from drupal:9.0.0.',
+                'Method Drupal\Core\Entity\EntityManager::clearDisplayModeInfo() should return $this(Drupal\Core\Entity\EntityManager) but return statement is missing.'
             ]
         ];
         yield [
@@ -46,5 +47,13 @@ public function dataDeprecatedSamples(): \Generator
                 'Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.',
             ]
         ];
+        yield [
+            __DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/src/UsesDeprecatedServiceMethod.php',
+            2,
+            [
+                '\Drupal calls should be avoided in classes, use dependency injection instead',
+                'Call to deprecated method getDefinitions() of class',
+            ]
+        ];
     }
 }

tests/src/DrupalIntegrationTest.php

@@ -31,6 +31,7 @@ public function testDrupalTestInChildSiteContant() {
     public function testExtensionReportsError() {
         $errors = $this->runAnalyze(__DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/phpstan_fixtures.module');
         $this->assertCount(1, $errors);
+        $this->assertEquals('Function phpstan_fixtures_MissingReturnRule() should return string but return statement is missing.', $errors[0]->getMessage());
     }
 
 }