Merge pull request #107 from mglaman/test-level-4

Test at level 4

Author: mglaman

tests/fixtures/drupal/modules/phpstan_fixtures/src/DeprecatedGlobalConstants.php

@@ -6,6 +6,6 @@ class DeprecatedGlobalConstants {
     public function test() {
         $date = new \DateTime();
         $date->setTimezone(new \DateTimeZone(DATETIME_STORAGE_TIMEZONE));
-        $date->format(DATETIME_DATE_STORAGE_FORMAT);
+        $formatted = $date->format(DATETIME_DATE_STORAGE_FORMAT);
     }
 }

tests/fixtures/drupal/modules/phpstan_fixtures/src/Entity/ReflectionEntityTest.php

@@ -0,0 +1,61 @@
+<?php declare(strict_types=1);
+
+namespace Drupal\phpstan_fixtures\Entity;
+
+use Drupal\Core\Entity\ContentEntityBase;
+use Drupal\Core\Entity\EntityTypeInterface;
+use Drupal\Core\Field\BaseFieldDefinition;
+use Drupal\user\UserInterface;
+
+final class ReflectionEntityTest extends ContentEntityBase {
+
+    public static function baseFieldDefinitions(EntityTypeInterface $entity_type)
+    {
+        $fields = parent::baseFieldDefinitions($entity_type);
+        $fields['user_id'] = BaseFieldDefinition::create('entity_reference')
+            ->setLabel(t('User ID'))
+            ->setDescription(t('The ID of the associated user.'))
+            ->setSetting('target_type', 'user')
+            ->setSetting('handler', 'default')
+            // Default EntityTest entities to have the root user as the owner, to
+            // simplify testing.
+            ->setDefaultValue([0 => ['target_id' => 1]])
+            ->setTranslatable(TRUE)
+            ->setDefaultValueCallback([static::class, 'getDefaultEntityOwner'])
+            ->setDisplayOptions('form', [
+                'type' => 'entity_reference_autocomplete',
+                'weight' => -1,
+                'settings' => [
+                    'match_operator' => 'CONTAINS',
+                    'size' => '60',
+                    'placeholder' => '',
+                ],
+            ]);
+        return $fields;
+    }
+
+    public function getOwnerId(): int {
+        return $this->get('user_id')->target_id;
+    }
+
+    public function setOwnerId($uid): ReflectionEntityTest {
+        $this->set('user_id', $uid);
+
+        return $this;
+    }
+
+    public function getOwner(): UserInterface {
+        return $this->get('user_id')->entity;
+    }
+
+    public function setOwner(UserInterface $account): ReflectionEntityTest {
+        $this->set('user_id', $account);
+
+        return $this;
+    }
+
+    public static function getDefaultEntityOwner(): int {
+        return \Drupal::currentUser()->id();
+    }
+
+}

tests/src/AnalyzerTestBase.php

@@ -16,7 +16,7 @@ protected function runAnalyze(string $path) {
         $containerFactory = new ContainerFactory($rootDir);
 
         $additionalConfigFiles = [
-            \sprintf('%s/config.level%s.neon', $containerFactory->getConfigDirectory(), 2),
+            \sprintf('%s/config.level%s.neon', $containerFactory->getConfigDirectory(), 4),
             __DIR__ . '/../fixtures/config/phpunit-drupal-phpstan.neon',
         ];
         $container = $containerFactory->create($tmpDir, $additionalConfigFiles, []);

tests/src/BootstrapTest.php

@@ -48,7 +48,7 @@ private function doDrupalBootstrap()
         $tmpDir = sys_get_temp_dir() . '/' . time() . 'phpstan';
         $containerFactory = new ContainerFactory($rootDir);
         $additionalConfigFiles = [
-            \sprintf('%s/config.level%s.neon', $containerFactory->getConfigDirectory(), 2),
+            \sprintf('%s/config.level%s.neon', $containerFactory->getConfigDirectory(), 4),
             __DIR__ . '/../fixtures/config/phpunit-drupal-phpstan.neon',
         ];
         $container = $containerFactory->create($tmpDir, $additionalConfigFiles, []);

tests/src/DeprecationRulesTest.php

@@ -11,7 +11,7 @@ class DeprecationRulesTest extends AnalyzerTestBase
     public function testDeprecationRules(string $path, int $count, array $errorMessages)
     {
         $errors = $this->runAnalyze($path);
-        $this->assertCount($count, $errors);
+        $this->assertCount($count, $errors, var_export($errors, true));
         foreach ($errors as $key => $error) {
             $this->assertEquals($errorMessages[$key], $error->getMessage());
         }
@@ -32,10 +32,11 @@ public function dataDeprecatedSamples(): \Generator
         ];
         yield [
             __DIR__ . '/../fixtures/drupal/core/lib/Drupal/Core/Entity/EntityManager.php',
-            2,
+            3,
             [
                 'Class Drupal\Core\Entity\EntityManager implements deprecated interface Drupal\Core\Entity\EntityManagerInterface:
 in drupal:8.0.0 and is removed from drupal:9.0.0.',
+                'Method Drupal\\Core\\Entity\\EntityManager::setFieldMap() should return $this(Drupal\\Core\\Entity\\EntityManager) but returns Drupal\\Core\\Entity\\EntityFieldManager.',
                 'Method Drupal\Core\Entity\EntityManager::clearDisplayModeInfo() should return $this(Drupal\Core\Entity\EntityManager) but return statement is missing.'
             ]
         ];

tests/src/DrupalIntegrationTest.php

@@ -30,8 +30,11 @@ public function testDrupalTestInChildSiteContant() {
 
     public function testExtensionReportsError() {
         $errors = $this->runAnalyze(__DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/phpstan_fixtures.module');
-        $this->assertCount(1, $errors);
-        $this->assertEquals('Function phpstan_fixtures_MissingReturnRule() should return string but return statement is missing.', $errors[0]->getMessage());
+        $this->assertCount(2, $errors, var_export($errors, true));
+        $error = array_shift($errors);
+        $this->assertEquals('If condition is always false.', $error->getMessage());
+        $error = array_shift($errors);
+        $this->assertEquals('Function phpstan_fixtures_MissingReturnRule() should return string but return statement is missing.', $error->getMessage());
     }
 
     public function testServiceMapping() {

tests/src/EntityTestClass.php

@@ -7,14 +7,31 @@ final class EntityTestClass extends AnalyzerTestBase
     /**
      * @dataProvider dataEntitySamples
      */
-    public function testEntityFields(string $path, int $count, array $errorMessages) {
+    public function testEntityFields(string $path, int $count, array $errorMessages): void
+    {
         $errors = $this->runAnalyze($path);
         $this->assertCount($count, $errors, print_r($errors, true));
         foreach ($errors as $key => $error) {
             $this->assertEquals($errorMessages[$key], $error->getMessage());
         }
     }
 
+    public function testEntityReferenceTargetIdPropertyReflection(): void
+    {
+        $errors = $this->runAnalyze(__DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/src/Entity/ReflectionEntityTest.php');
+        $this->assertCount(2, $errors, print_r($errors, true));
+        $error = array_shift($errors);
+        $this->assertEquals(
+            'Method Drupal\phpstan_fixtures\Entity\ReflectionEntityTest::getOwnerId() should return int but returns string.',
+            $error->getMessage()
+        );
+        $error = array_shift($errors);
+        $this->assertEquals(
+            'Method Drupal\phpstan_fixtures\Entity\ReflectionEntityTest::getOwner() should return Drupal\user\UserInterface but returns Drupal\Core\Entity\EntityInterface.',
+            $error->getMessage()
+        );
+    }
+
 
     public function dataEntitySamples(): \Generator
     {

tests/src/ServiceProviderAutoloadingTest.php

@@ -20,8 +20,8 @@ public function dataEntitySamples(): \Generator
     {
         yield [
             __DIR__ . '/../fixtures/drupal/modules/service_provider_test/src/ServiceProviderTestServiceProvider.php',
-            0,
-            []
+            1,
+            ['If condition is always true.']
         ];
     }
 }