Merge pull request #312 from mglaman/gh311

Exclude InstallerExistingConfigTestBase from $defaultTheme rule

Author: mglaman

src/Rules/Drupal/Tests/BrowserTestBaseDefaultThemeRule.php

@@ -7,6 +7,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\TypeCombinator;
 
 final class BrowserTestBaseDefaultThemeRule implements Rule
 {
@@ -31,12 +32,17 @@ public function processNode(Node $node, Scope $scope): array
 
         $classType = $scope->resolveTypeByName($node->namespacedName);
         assert($classType instanceof ObjectType);
-        $browserTestBaseAncestor = $classType->getAncestorWithClassName('Drupal\\Tests\\BrowserTestBase');
-        if ($browserTestBaseAncestor === null) {
+
+        $browserTestBaseType = new ObjectType('Drupal\\Tests\\BrowserTestBase');
+        if (!$browserTestBaseType->isSuperTypeOf($classType)->yes()) {
             return [];
         }
-        $browserTestBaseAncestor = $classType->getAncestorWithClassName('Drupal\\FunctionalTests\\Update\\UpdatePathTestBase');
-        if ($browserTestBaseAncestor !== null) {
+
+        $excludedTestTypes = TypeCombinator::union(
+            new ObjectType('Drupal\\FunctionalTests\\Update\\UpdatePathTestBase'),
+            new ObjectType('Drupal\\FunctionalTests\\Installer\\InstallerExistingConfigTestBase')
+        );
+        if ($excludedTestTypes->isSuperTypeOf($classType)->yes()) {
             return [];
         }
 

tests/src/Rules/BrowserTestBaseDefaultThemeRuleTest.php

@@ -57,6 +57,14 @@ public function fileData(): \Generator
             __DIR__ . '/../../fixtures/drupal/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBaseTest.php',
             []
         ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/tests/Drupal/FunctionalTests/Installer/InstallerExistingConfigNoSystemSiteTest.php',
+            []
+        ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/tests/Drupal/FunctionalTests/Installer/InstallerExistingConfigTest.php',
+            []
+        ];
     }
 
 }