Analyze autoloader and phpunit-hack file

Author: mglaman

.github/workflows/php.yml

@@ -49,7 +49,7 @@ jobs:
       - name: "PHPCS"
         run: "php vendor/bin/phpcs src"
       - name: "PHPStan"
-        run: "php vendor/bin/phpstan analyze src"
+        run: "php vendor/bin/phpstan analyze"
       - name: "PHPUnit"
         run: "php vendor/bin/phpunit --debug"
 

drupal-autoloader.php

@@ -3,8 +3,10 @@
 use mglaman\PHPStanDrupal\Drupal\DrupalAutoloader;
 use PHPStan\DependencyInjection\Container;
 
-assert($container instanceof Container);
-if ($container === NULL && !($container instanceof Container)) {
+if (!isset($container)) {
+    throw new \PHPStan\ShouldNotHappenException('The autoloader did not receive the container.');
+}
+if (!$container instanceof Container) {
     throw new \PHPStan\ShouldNotHappenException('The autoloader did not receive the container.');
 }
 

drupal-phpunit-hack.php

@@ -19,10 +19,17 @@
 
 // Inspired by Symfony's simple-phpunit remove typehints from TestCase.
 $alteredFile = $autoloader->findFile('PHPUnit\Framework\TestCase');
+if ($alteredFile === false) {
+    return;
+}
 $phpunit_dir = dirname($alteredFile, 3);
 // Mutate TestCase code to make it compatible with Drupal 8 and 9 tests.
 $alteredCode = file_get_contents($alteredFile);
+if ($alteredCode === false) {
+    throw new \PHPStan\ShouldNotHappenException("Found $alteredFile but could not get its contents to fix return types.");
+}
 $alteredCode = preg_replace('/^    ((?:protected|public)(?: static)? function \w+\(\)): void/m', '    $1', $alteredCode);
+assert($alteredCode !== null);
 $alteredCode = str_replace("__DIR__ . '/../Util/", "'$phpunit_dir/src/Util/", $alteredCode);
 // Only write when necessary.
 $filename = __DIR__ . '/tests/fixtures/TestCase.php';

phpstan.neon

@@ -5,3 +5,7 @@ parameters:
 	level: 8
 	checkGenericClassInNonGenericObjectType: false
 	checkMissingIterableValueType: false
+	paths:
+		- src
+		- drupal-phpunit-hack.php
+		- drupal-autoloader.php