Add PHP 8.3 to workflow (#729)

* Add PHP 8.3 to workflow

fixes #726

* d9 doesn't support 8.3

* RouteObjectInterface not found

* phpstan fixes

* phpcs

* more class_exist

* try something

* i don't get it!

* fix some logic

* // @phpstan-ignore-next-line

Author: mglaman

.github/workflows/php.yml

@@ -18,6 +18,7 @@ jobs:
           - "8.0"
           - "8.1"
           - "8.2"
+          - "8.3"
     steps:
       - name: "Checkout"
         uses: "actions/checkout@v4"
@@ -28,6 +29,12 @@ jobs:
           php-version: "${{ matrix.php-version }}"
           tools: composer:v2
           extensions: dom, curl, libxml, mbstring, zip, pdo, mysql, pdo_mysql, gd
+      - name: "Upgrade to drupal/core:^10"
+        run: "composer require drupal/core-recommended:^10 --with-all-dependencies --dev --no-update"
+        if: ${{ matrix.php-version == '8.3' }}
+      - name: "Add phpspec/prophecy-phpunit"
+        run: "composer require phpspec/prophecy-phpunit:^2 --dev --no-update"
+        if: ${{ matrix.php-version == '8.3' }}
       - name: "Install dependencies"
         uses: "ramsey/composer-install@v3"
       - name: "PHPCS"
@@ -61,6 +68,9 @@ jobs:
           - php-version: "8.2"
             drupal: "11.x-dev"
             experimental: true
+          - php-version: "8.3"
+            drupal: "11.x-dev"
+            experimental: true
     steps:
       - name: "Checkout"
         uses: "actions/checkout@v4"
@@ -105,6 +115,9 @@ jobs:
           - php-version: "8.2"
             drupal: "11.x-dev"
             experimental: true
+          - php-version: "8.3"
+            drupal: "11.x-dev"
+            experimental: true
     steps:
       - name: "Checkout"
         uses: "actions/checkout@v4"

src/Rules/Deprecations/SymfonyCmfRouteObjectInterfaceConstantsRule.php

@@ -42,9 +42,14 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
         [$major, $minor] = explode('.', Drupal::VERSION, 3);
-        if ($major !== '9' && (int) $minor > 1) {
+        if ($major !== '9') {
             return [];
         }
+        if ((int) $minor < 1) {
+            return [];
+        }
+
+        // @phpstan-ignore-next-line
         $cmfRouteObjectInterfaceType = new ObjectType(SymfonyRouteObjectInterface::class);
         if (!$classType->isSuperTypeOf($cmfRouteObjectInterfaceType)->yes()) {
             return [];

src/Rules/Deprecations/SymfonyCmfRoutingInClassMethodSignatureRule.php

@@ -39,8 +39,11 @@ public function processNode(Node $node, Scope $scope): array
         }
         $method = $node->getMethodReflection();
 
+        // @phpstan-ignore-next-line
         $cmfRouteObjectInterfaceType = new ObjectType(RouteObjectInterface::class);
+        // @phpstan-ignore-next-line
         $cmfRouteProviderInterfaceType = new ObjectType(RouteProviderInterface::class);
+        // @phpstan-ignore-next-line
         $cmfLazyRouteCollectionType = new ObjectType(LazyRouteCollection::class);
 
         $methodSignature = ParametersAcceptorSelector::selectSingle($method->getVariants());

src/Rules/Drupal/RequestStackGetMainRequestRule.php

@@ -3,7 +3,6 @@
 namespace mglaman\PHPStanDrupal\Rules\Drupal;
 
 use Drupal;
-use Drupal\Core\Http\RequestStack as DrupalRequestStack;
 use mglaman\PHPStanDrupal\Internal\DeprecatedScopeCheck;
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
@@ -32,7 +31,7 @@ public function processNode(Node $node, Scope $scope): array
         }
         [$major, $minor] = explode('.', Drupal::VERSION, 3);
         // Only valid for 9.3 -> 9.5. Deprecated in Drupal 10.
-        if ($major !== '9' || (int) $minor < 3) {
+        if (($major !== '9' || (int) $minor < 3)) {
             return [];
         }
         if (!$node->name instanceof Node\Identifier) {
@@ -48,7 +47,7 @@ public function processNode(Node $node, Scope $scope): array
             $message = sprintf(
                 '%s::getMasterRequest() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0 for Symfony 6 compatibility. Use the forward compatibility shim class %s and its getMainRequest() method instead.',
                 SymfonyRequestStack::class,
-                DrupalRequestStack::class
+                'Drupal\Core\Http\RequestStack'
             );
             return [
                 RuleErrorBuilder::message($message)