Stricter check in RenderCallbackRule for $matches (#831)

mglaman · web-flow · commit a461737148eb · 2025-03-27T09:24:27.000-05:00
diff --git a/src/Rules/Drupal/RenderCallbackRule.php b/src/Rules/Drupal/RenderCallbackRule.php
@@ -324,7 +324,7 @@ private function getType(Node\Expr $node, Scope $scope):  Type
             }
             // @see \PHPStan\Type\Constant\ConstantStringType::isCallable
             preg_match('#^([a-zA-Z_\\x7f-\\xff\\\\][a-zA-Z0-9_\\x7f-\\xff\\\\]*)::([a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]*)\\z#', $type->getValue(), $matches);
-            if (count($matches) > 0) {
+            if (count($matches) === 3) {
                 return new ConstantArrayType(
                     [new ConstantIntegerType(0), new ConstantIntegerType(1)],
                     [

Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ private function getType(Node\Expr $node, Scope $scope): Type`
`324`	`324`	`}`
`325`	`325`	`// @see \PHPStan\Type\Constant\ConstantStringType::isCallable`
`326`	`326`	`preg_match('#^([a-zA-Z_\\x7f-\\xff\\\\][a-zA-Z0-9_\\x7f-\\xff\\\\])::([a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff])\\z#', $type->getValue(), $matches);`
`327`		`- if (count($matches) > 0) {`
	`327`	`+ if (count($matches) === 3) {`
`328`	`328`	`return new ConstantArrayType(`
`329`	`329`	`[new ConstantIntegerType(0), new ConstantIntegerType(1)],`
`330`	`330`	`[`