Merge pull request #453 from mglaman/filterprocessresult-stub

Add generic callable check for RenderCallbackRule

Author: mglaman

src/Rules/Drupal/RenderCallbackRule.php

@@ -192,6 +192,9 @@ private function doProcessNode(Node\Expr $node, Scope $scope, string $keyChecked
                     sprintf("%s callback %s at key '%s' is not callable.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
                 )->line($errorLine)->build();
             }
+        } elseif ($type->isCallable()->yes()) {
+            // If the value has been marked as callable or callable-string, we cannot resolve the callable, trust it.
+            return null;
         } else {
             return RuleErrorBuilder::message(
                 sprintf("%s value '%s' at key '%s' is invalid.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)

stubs/Drupal/Core/Cache/CacheableDependencyInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Cache;
+
+interface CacheableDependencyInterface {
+
+}

stubs/Drupal/Core/Cache/CacheableMetadata.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Cache;
+
+class CacheableMetadata implements RefinableCacheableDependencyInterface {
+
+}

stubs/Drupal/Core/Cache/RefinableCacheableDependencyInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Cache;
+
+interface RefinableCacheableDependencyInterface extends CacheableDependencyInterface {
+
+}

stubs/Drupal/Core/Render/AttachmentsInterface.stub

@@ -0,0 +1,7 @@
+<?php
+
+namespace Drupal\Core\Render;
+
+interface AttachmentsInterface {
+
+}

stubs/Drupal/Core/Render/BubbleableMetadata.stub

@@ -0,0 +1,9 @@
+<?php
+
+namespace Drupal\Core\Render;
+
+use Drupal\Core\Cache\CacheableMetadata;
+
+class BubbleableMetadata extends CacheableMetadata implements AttachmentsInterface {
+
+}

stubs/Drupal/filter/FilterProcessResult.stub

@@ -0,0 +1,16 @@
+<?php
+
+namespace Drupal\filter;
+
+use Drupal\Core\Render\BubbleableMetadata;
+
+class FilterProcessResult extends BubbleableMetadata {
+
+    /**
+     * @param callable-string $callback
+     * @param array<int|string, mixed> $args
+     */
+    public function createPlaceholder($callback, array $args): string {
+
+    }
+}

tests/src/Rules/RenderCallbackRuleTest.php

@@ -111,6 +111,10 @@ public function fileData(): \Generator
                 ]
             ]
         ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/modules/filter/src/FilterProcessResult.php',
+            []
+        ];
     }