Merge pull request #235 from mglaman/gh234

BrowserTestBaseDefaultThemeRule false positives with UpdatePathTests

Author: mglaman

src/Rules/Drupal/Tests/BrowserTestBaseDefaultThemeRule.php

@@ -32,6 +32,10 @@ public function processNode(Node $node, Scope $scope): array
         if ($browserTestBaseAncestor === null) {
             return [];
         }
+        $browserTestBaseAncestor = $classType->getAncestorWithClassName('Drupal\\FunctionalTests\\Update\\UpdatePathTestBase');
+        if ($browserTestBaseAncestor !== null) {
+            return [];
+        }
 
         $reflection = $classType->getClassReflection();
         assert($reflection !== null);

tests/src/Rules/BrowserTestBaseDefaultThemeRuleTest.php

@@ -53,6 +53,10 @@ public function fileData(): \Generator
             __DIR__ . '/../../fixtures/drupal/core/modules/views/tests/src/Functional/ViewTestBase.php',
             []
         ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBaseTest.php',
+            []
+        ];
     }
 
 }