Add test for app.root union error

Author: mglaman

src/Type/ServiceDynamicReturnTypeExtension.php

@@ -11,6 +11,7 @@
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Constant\ConstantBooleanType;
+use Psr\Container\ContainerInterface;
 
 class ServiceDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
@@ -26,7 +27,7 @@ public function __construct(ServiceMap $serviceMap)
 
     public function getClass(): string
     {
-        return 'Symfony\Component\DependencyInjection\ContainerInterface';
+        return ContainerInterface::class;
     }
 
     public function isMethodSupported(MethodReflection $methodReflection): bool

tests/fixtures/drupal/modules/phpstan_fixtures/phpstan_fixtures.module

@@ -11,3 +11,8 @@ function phpstan_fixtures_IfConstantConditionRule() {
 function phpstan_fixtures_MissingReturnRule(): string {
 
 }
+
+function phpstan_fixtures_get_app_root(): string {
+    $app_root = \Drupal::getContainer()->get('app.root');
+    return $app_root . '/core/includes/install.inc';
+}

tests/fixtures/drupal/modules/phpstan_fixtures/src/AppRootParameter.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types=1);
+
+namespace Drupal\phpstan_fixtures;
+
+use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+
+final class AppRootParameter implements ContainerInjectionInterface {
+
+    private $appRoot;
+
+    /**
+     * {@inheritdoc}
+     */
+    public static function create(ContainerInterface $container)
+    {
+        return new self($container->get('app.root'));
+    }
+
+    /**
+     * AppRootParameter constructor.
+     *
+     * @param string $app_root
+     *   The app root.
+     */
+    public function __construct(string $app_root)
+    {
+        $this->appRoot = $app_root;
+    }
+
+    public function testUnion(): string {
+        return $this->appRoot . '/core';
+    }
+}

tests/src/DrupalIntegrationTest.php

@@ -60,4 +60,10 @@ public function testServiceMapping() {
             $this->assertEquals($errorMessages[$key], $error->getMessage());
         }
     }
+
+    public function testAppRootPseudoService() {
+        $errorMessages = [];
+        $errors = $this->runAnalyze(__DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/src/AppRootParameter.php');
+        $this->assertCount(0, $errors, var_export($errors, TRUE));
+    }
 }