Skip to content

Commit 1bd86ea

Browse files
shvaikaleshmgol
authored andcommitted
Drop node < 4 support, don't transpile code
Closes #24
1 parent e939d9b commit 1bd86ea

File tree

13 files changed

+53
-192
lines changed

13 files changed

+53
-192
lines changed

.babelrc

Lines changed: 0 additions & 4 deletions
This file was deleted.

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
node_modules/**
2-
dist/**
32
test/*/**/*.js

.eslintrc.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,11 @@
55

66
"env": {
77
"node": true
8+
},
9+
10+
"rules": {
11+
"prefer-reflect": 0,
12+
"prefer-rest-params": 0,
13+
"prefer-spread": 0
814
}
915
}

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
/node_modules/
2-
/dist/
32
*.log
43
/test/*/*-copy
54
/test/*-fixtures/generated/

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
language: node_js
22
sudo: false
33
node_js:
4-
- '0.12'
54
- '4'
65
- '6'
76
env:

Gruntfile.js

Lines changed: 3 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -1,84 +1,22 @@
11
'use strict';
22

3-
// Disable options that don't work in Node.js 0.12.
4-
// Gruntfile.js & tasks/*.js are the only non-transpiled files.
5-
/* eslint-disable no-var, object-shorthand, prefer-arrow-callback, prefer-const,
6-
prefer-spread, prefer-reflect, prefer-rest-params, prefer-template */
7-
8-
var assert = require('assert');
9-
10-
var newNode;
11-
try {
12-
assert.strictEqual(eval('(r => [...r])([2])[0]'), 2); // eslint-disable-line no-eval
13-
newNode = true;
14-
} catch (e) {
15-
newNode = false;
16-
}
17-
18-
var tooOldNodeForTheTask = /^v0\./.test(process.version);
19-
20-
// Support: Node.js <4
21-
// Skip running tasks that dropped support for Node.js 0.10 & 0.12
22-
// in those Node versions.
23-
var runIfNewNode = function (task) {
24-
return tooOldNodeForTheTask ? 'print_old_node_message:' + task : task;
25-
};
26-
273
module.exports = function (grunt) {
284
require('time-grunt')(grunt);
295

306
grunt.initConfig({
317
clean: {
328
all: {
339
src: [
34-
'dist',
3510
'*.log',
3611
'test/*/*-copy',
3712
'test/*-fixtures/generated',
3813
],
3914
},
4015
},
4116

42-
copy: {
43-
all: {
44-
files: [
45-
{
46-
expand: true,
47-
dot: true,
48-
src: [
49-
'test/**/*',
50-
'!test/**/*.js',
51-
],
52-
dest: 'dist',
53-
},
54-
],
55-
},
56-
},
57-
58-
babel: {
59-
options: {
60-
sourceMap: true,
61-
retainLines: true,
62-
},
63-
all: {
64-
files: [
65-
{
66-
expand: true,
67-
src: [
68-
'bin/**/*.js',
69-
'lib/**/*.js',
70-
'test/**/*.js',
71-
],
72-
dest: 'dist',
73-
},
74-
],
75-
},
76-
},
77-
7817
eslint: {
7918
all: {
8019
src: [
81-
'*.js',
8220
'bin',
8321
'lib',
8422
'test',
@@ -91,41 +29,20 @@ module.exports = function (grunt) {
9129
options: {
9230
reporter: 'spec',
9331
},
94-
src: [newNode ? 'test/spec.js' : 'dist/test/spec.js'],
32+
src: 'test/spec.js',
9533
},
9634
},
9735
});
9836

9937
// Load grunt tasks from NPM packages
100-
// Support: Node.js <4
101-
// Don't load the eslint task in old Node.js, it won't parse.
102-
require('load-grunt-tasks')(grunt, {
103-
pattern: tooOldNodeForTheTask ? ['grunt-*', '!grunt-eslint'] : ['grunt-*'],
104-
});
105-
106-
// Supports: Node.js <4
107-
grunt.registerTask('print_old_node_message', function () {
108-
var task = [].slice.call(arguments).join(':');
109-
grunt.log.writeln('Old Node.js detected, running the task "' + task + '" skipped...');
110-
});
111-
112-
grunt.registerTask('lint', [
113-
runIfNewNode('eslint'),
114-
]);
115-
116-
// In modern Node.js we just use the non-transpiled source as it makes it easier to debug;
117-
// in older version we transpile (but keep the lines).
118-
grunt.registerTask('build', [
119-
'copy',
120-
'babel',
121-
]);
38+
require('load-grunt-tasks')(grunt);
12239

40+
grunt.registerTask('lint', ['eslint']);
12341
grunt.registerTask('test', ['mochaTest']);
12442

12543
grunt.registerTask('default', [
12644
'clean',
12745
'lint',
128-
'build',
12946
'test',
13047
]);
13148
};

appveyor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ init:
99
# Test against these versions of Node.js.
1010
environment:
1111
matrix:
12-
- nodejs_version: "0.12"
12+
- nodejs_version: "4"
1313
- nodejs_version: "6"
1414

1515
# Install scripts. (runs after repo cloning)
@@ -37,7 +37,7 @@ build: off
3737
matrix:
3838
# fast_finish: true
3939
allow_failures:
40-
- nodejs_version: "6"
40+
- nodejs_version: "4"
4141

4242
# Set up cache, clear it on package.json changes.
4343
# NOTE: Cache disabled for now.

bin.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

bin/cli.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@
33
'use strict';
44

55
const minimist = require('minimist');
6-
const _ = require('lodash');
6+
const camelCase = require('lodash.camelcase');
77
const checkDependencies = require('../lib/check-dependencies');
88

99
const argv = minimist(process.argv.slice(2));
1010

1111
// camelCase the options
12-
for (const key in argv) {
12+
for (const key of Object.keys(argv)) {
1313
const value = argv[key];
1414
delete argv[key];
15-
argv[_.camelCase(key)] = value;
15+
argv[camelCase(key)] = value;
1616
}
1717

1818
// Options of type array should always have array values

index.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)