Skip to content

Commit 6c7f755

Browse files
authored
Tests: Run tests on both real Firefox ESRs
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Contrary to what we did in jquerygh-5547, still run tests on Firefox 115 on BrowserStack - on `main`, we deleted it since we support only the versions supported upstream. In jQuery 3.x, we're testing on all versions matching ESR lines starting with Firefox 48, so for consistency let's keep Firefox 115 there as well. Closes jquerygh-5548 Ref jquerygh-5547
1 parent 8037b9f commit 6c7f755

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

.github/workflows/node.js.yml

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ jobs:
3737
- NAME: "Chrome"
3838
NODE_VERSION: "20.x"
3939
NPM_SCRIPT: "test:amd"
40-
- NAME: "Firefox ESR"
40+
- NAME: "Firefox ESR (new)"
41+
NODE_VERSION: "20.x"
42+
NPM_SCRIPT: "test:firefox"
43+
- NAME: "Firefox ESR (old)"
4144
NODE_VERSION: "20.x"
4245
NPM_SCRIPT: "test:firefox"
4346
steps:
@@ -57,10 +60,21 @@ jobs:
5760
restore-keys: |
5861
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-npm-lock-
5962
60-
- name: Install firefox ESR
63+
- name: Set download URL for Firefox ESR (old)
64+
run: |
65+
echo "FIREFOX_SOURCE_URL=https://download.mozilla.org/?product=firefox-esr-latest-ssl&lang=en-US&os=linux64" >> "$GITHUB_ENV"
66+
if: contains(matrix.NAME, 'Firefox ESR (old)')
67+
68+
- name: Set download URL for Firefox ESR (new)
69+
run: |
70+
echo "FIREFOX_SOURCE_URL=https://download.mozilla.org/?product=firefox-esr-next-latest-ssl&lang=en-US&os=linux64" >> "$GITHUB_ENV"
71+
if: contains(matrix.NAME, 'Firefox ESR (new)')
72+
73+
- name: Install Firefox ESR
6174
run: |
62-
export FIREFOX_SOURCE_URL='https://download.mozilla.org/?product=firefox-esr-latest-ssl&lang=en-US&os=linux64'
6375
wget --no-verbose $FIREFOX_SOURCE_URL -O - | tar -jx -C ${HOME}
76+
echo "PATH=${HOME}/firefox:$PATH" >> "$GITHUB_ENV"
77+
echo "FIREFOX_BIN=${HOME}/firefox/firefox" >> "$GITHUB_ENV"
6478
if: contains(matrix.NAME, 'Firefox ESR')
6579

6680
- name: Install dependencies
@@ -71,10 +85,7 @@ jobs:
7185
if: contains(matrix.NPM_SCRIPT, 'lint')
7286

7387
- name: Run tests
74-
run: |
75-
export PATH=${HOME}/firefox:$PATH
76-
export FIREFOX_BIN=${HOME}/firefox/firefox
77-
npm run ${{ matrix.NPM_SCRIPT }}
88+
run: npm run ${{ matrix.NPM_SCRIPT }}
7889

7990
safari:
8091
runs-on: macos-latest

0 commit comments

Comments
 (0)