Build: improve specificity of eslint config; add ecma versions

- also added no-implicit-globals rule outside of tests,
  but including dist

Close jquerygh-5504

Author: timmywil

eslint.config.js

@@ -15,30 +15,11 @@ module.exports = [
 		]
 	},
 
-	{
-		files: [
-			"eslint.config.js",
-			"Gruntfile.js",
-			"test/node_smoke_tests/**",
-			"test/promises_aplus_adapters/**",
-			"test/middleware-mockserver.js"
-		],
-		languageOptions: {
-			globals: {
-				...globals.node
-			},
-			sourceType: "commonjs"
-		},
-		rules: {
-			...jqueryConfig.rules,
-			strict: [ "error", "global" ]
-		}
-	},
-
 	// Source
 	{
 		files: [ "src/**" ],
 		languageOptions: {
+			ecmaVersion: 2015,
 
 			// The browser env is not enabled on purpose so that code takes
 			// all browser-only globals from window instead of assuming
@@ -65,6 +46,7 @@ module.exports = [
 					]
 				}
 			],
+			"no-implicit-globals": "error",
 			"one-var": [ "error", { var: "always" } ],
 			strict: [ "error", "function" ]
 		}
@@ -117,7 +99,10 @@ module.exports = [
 	// Tests
 	{
 		files: [
-			"test/**"
+			"test/*",
+			"test/data/**",
+			"test/integration/**",
+			"test/unit/**"
 		],
 		ignores: [
 			"test/data/jquery-3.7.1.js",
@@ -128,11 +113,11 @@ module.exports = [
 			"test/data/core/jquery-iterability-transpiled.js"
 		],
 		languageOptions: {
+			ecmaVersion: 2015,
+			sourceType: "script",
 			globals: {
 				...globals.browser,
 				require: false,
-				Promise: false,
-				Symbol: false,
 				trustedTypes: false,
 				QUnit: false,
 				ajaxTest: false,
@@ -144,32 +129,54 @@ module.exports = [
 				moduleTeardown: false,
 				url: false,
 				q: false,
-				jQuery: true,
-				sinon: true,
-				amdDefined: true,
-				fireNative: true,
-				Globals: true,
-				hasPHP: true,
-				isLocal: true,
-				supportjQuery: true,
-				originaljQuery: true,
-				$: true,
-				original$: true,
-				baseURL: true,
-				externalHost: true
+				jQuery: false,
+				$: false,
+				sinon: false,
+				amdDefined: false,
+				fireNative: false,
+				Globals: false,
+				hasPHP: false,
+				isLocal: false,
+				supportjQuery: false,
+				originaljQuery: false,
+				original$: false,
+				baseURL: false,
+				externalHost: false
 			}
 		},
 		rules: {
 			...jqueryConfig.rules,
-			strict: [ "error", "function" ],
 
-			// See https://github.com/eslint/eslint/issues/2342
-			"no-unused-vars": "off",
+			"no-unused-vars": [
+				"error",
+				{ args: "after-used", argsIgnorePattern: "^_" }
+			],
 
 			// Too many errors
 			"max-len": "off",
-			camelcase: "off",
-			"one-var": "off"
+			camelcase: "off"
+		}
+	},
+
+	{
+		files: [
+			"test/jquery.js"
+		],
+		languageOptions: {
+			globals: {
+				loadTests: false
+			}
+		}
+	},
+
+	{
+		files: [
+			"test/unit/core.js"
+		],
+		rules: {
+
+			// Core has several cases where unused vars are expected
+			"no-unused-vars": "off"
 		}
 	},
 
@@ -178,86 +185,99 @@ module.exports = [
 			"test/runner/**/*.js"
 		],
 		languageOptions: {
+			ecmaVersion: "latest",
 			globals: {
 				...globals.node
-			},
-			sourceType: "module"
+			}
 		},
 		rules: {
-			...jqueryConfig.rules
+			...jqueryConfig.rules,
+			"no-implicit-globals": "error"
 		}
 	},
 
 	{
 		files: [ "test/runner/listeners.js" ],
 		languageOptions: {
 			ecmaVersion: 5,
-			sourceType: "script"
+			sourceType: "script",
+			globals: {
+				...globals.browser,
+				QUnit: false,
+				Symbol: false
+			}
 		}
 	},
 
 	{
 		files: [
+			"test/data/testinit.js",
 			"test/data/testrunner.js",
 			"test/data/core/jquery-iterability-transpiled-es6.js"
 		],
 		languageOptions: {
-			sourceType: "script"
+			ecmaVersion: 2015,
+			sourceType: "script",
+			globals: {
+				...globals.browser
+			}
+		},
+		rules: {
+			...jqueryConfig.rules,
+			strict: [ "error", "function" ]
 		}
 	},
 
 	{
 		files: [
-			"test/unit/deferred.js"
+			"test/data/testinit.js"
 		],
 		rules: {
-
-			// Deferred tests set strict mode for certain tests
-			strict: "off"
+			strict: [ "error", "global" ]
 		}
 	},
 
 	{
 		files: [
-			"test/node_smoke_tests/**",
-			"test/promises_aplus_adapters/**",
-			"test/middleware-mockserver.js"
+			"test/unit/deferred.js"
 		],
-		languageOptions: {
-			globals: {
-				...globals.node,
-				...globals.es2021
-			}
-		},
 		rules: {
-			strict: [ "error", "global" ]
+
+			// Deferred tests set strict mode for certain tests
+			strict: "off"
 		}
 	},
 
 	{
 		files: [
 			"build/**",
-			"test/data/testinit.js"
+			"eslint.config.js",
+			"test/node_smoke_tests/**",
+			"test/bundler_smoke_tests/**/*",
+			"test/promises_aplus_adapters/**",
+			"test/middleware-mockserver.js"
 		],
 		languageOptions: {
+			ecmaVersion: "latest",
+			sourceType: "commonjs",
 			globals: {
-				...globals.node,
-				...globals.es2021
+				...globals.browser,
+				...globals.node
 			}
 		},
 		rules: {
 			...jqueryConfig.rules,
+			"no-implicit-globals": "error",
 			strict: [ "error", "global" ]
 		}
 	},
 
 	{
 		files: [
-			"build/**/*.js",
-			"test/data/testinit.js"
+			"**/*.mjs"
 		],
 		languageOptions: {
-			sourceType: "commonjs"
+			sourceType: "module"
 		}
 	},
 
@@ -266,20 +286,19 @@ module.exports = [
 			"dist/jquery.js",
 			"dist/jquery.slim.js"
 		],
-
 		languageOptions: {
 			globals: {
-				...globals.browser,
-				...globals.es2021,
 				define: false,
 				module: false,
-				Symbol: false
+				Symbol: false,
+				window: false
 			}
 		},
-
 		rules: {
 			...jqueryConfig.rules,
 
+			"no-implicit-globals": "error",
+
 			// That is okay for the built version
 			"no-multiple-empty-lines": "off",
 
@@ -288,5 +307,15 @@ module.exports = [
 			"max-len": "off",
 			"one-var": "off"
 		}
+	},
+
+	{
+		files: [
+			"dist/**"
+		],
+		languageOptions: {
+			ecmaVersion: 5,
+			sourceType: "script"
+		}
 	}
 ];

test/data/csp-nonce-external.js

@@ -1,5 +1,3 @@
-/* global startIframeTest */
-
 jQuery( function() {
 	$( "body" ).append( "<script nonce='jquery+hardcoded+nonce' src='csp-nonce.js'></script>" );
 } );

test/data/csp-nonce-globaleval.js

@@ -1,5 +1,3 @@
-/* global startIframeTest */
-
 jQuery( function() {
 	$.globalEval( "startIframeTest()", { nonce: "jquery+hardcoded+nonce" } );
 } );

test/data/csp-nonce.js

@@ -1,5 +1,3 @@
-/* global startIframeTest */
-
 jQuery( function() {
 	var script = document.createElement( "script" );
 	script.setAttribute( "nonce", "jquery+hardcoded+nonce" );

test/jquery.js

@@ -1,7 +1,5 @@
 // Use the right jQuery source on the test page (and iframes)
 ( function() {
-	/* global loadTests: false */
-
 	var config, src,
 		parentUrl = window.location.protocol + "//" + window.location.host,
 		QUnit = window.QUnit,

test/unit/attributes.js

@@ -261,7 +261,7 @@ QUnit.test( "attr(String, Object)", function( assert ) {
 
 	var $input, $text, $details,
 		attributeNode, commentNode, textNode, obj,
-		table, td, j, type,
+		table, td, j,
 		check, thrown, button, $radio, $radios, $svg,
 		div = jQuery( "#qunit-fixture div" ).attr( "foo", "bar" ),
 		i = 0,
@@ -418,7 +418,6 @@ QUnit.test( "attr(String, Object)", function( assert ) {
 	j.removeAttr( "name" );
 
 	// Type
-	type = jQuery( "#check2" ).attr( "type" );
 	try {
 		jQuery( "#check2" ).attr( "type", "hidden" );
 		assert.ok( true, "No exception thrown on input type change" );

test/unit/css.js

@@ -7,7 +7,7 @@ QUnit.test( "css(String|Hash)", function( assert ) {
 
 	assert.equal( jQuery( "#qunit-fixture" ).css( "display" ), "block", "Check for css property \"display\"" );
 
-	var $child, div, div2, width, height, child, prctval, checkval, old;
+	var $child, div, div2, child, prctval, checkval, old;
 
 	$child = jQuery( "#nothiddendivchild" ).css( { "width": "20%", "height": "20%" } );
 	assert.notEqual( $child.css( "width" ), "20px", "Retrieving a width percentage on the child of a hidden div returns percentage" );
@@ -36,8 +36,6 @@ QUnit.test( "css(String|Hash)", function( assert ) {
 	// handle negative numbers by setting to zero trac-11604
 	jQuery( "#nothiddendiv" ).css( { "width": 1, "height": 1 } );
 
-	width = parseFloat( jQuery( "#nothiddendiv" ).css( "width" ) );
-	height = parseFloat( jQuery( "#nothiddendiv" ).css( "height" ) );
 	jQuery( "#nothiddendiv" ).css( { "overflow": "hidden", "width": -1, "height": -1 } );
 	assert.equal( parseFloat( jQuery( "#nothiddendiv" ).css( "width" ) ), 0, "Test negative width set to 0" );
 	assert.equal( parseFloat( jQuery( "#nothiddendiv" ).css( "height" ) ), 0, "Test negative height set to 0" );
@@ -274,8 +272,7 @@ QUnit.test( "css() non-px relative values (gh-1711)", function( assert ) {
 QUnit.test( "css() mismatched relative values with bounded styles (gh-2144)", function( assert ) {
 	assert.expect( 1 );
 
-	var right,
-		$container = jQuery( "<div></div>" )
+	var $container = jQuery( "<div></div>" )
 			.css( { position: "absolute", width: "400px", fontSize: "4px" } )
 			.appendTo( "#qunit-fixture" ),
 		$el = jQuery( "<div></div>" )

test/unit/data.js

@@ -317,6 +317,7 @@ QUnit.test( "data-* attributes", function( assert ) {
 
 	assert.equal( num, check.length, "Make sure that the right number of properties came through." );
 
+	/* eslint-disable-next-line no-unused-vars */
 	for ( prop in obj2 ) {
 		num2++;
 	}

test/unit/deferred.js

@@ -861,11 +861,11 @@ QUnit.test( "jQuery.when(nonThenable) - like Promise.resolve", function( assert
 		done = assert.async( 20 );
 
 	jQuery.when()
-		.done( function( resolveValue ) {
+		.done( function() {
 			assert.strictEqual( arguments.length, 0, "Resolved .done with no arguments" );
 			assert.strictEqual( this, defaultContext, "Default .done context with no arguments" );
 		} )
-		.then( function( resolveValue ) {
+		.then( function() {
 			assert.strictEqual( arguments.length, 0, "Resolved .then with no arguments" );
 			assert.strictEqual( this, defaultContext, "Default .then context with no arguments" );
 		} );