Skip to content

Commit ed18576

Browse files
committed
Tests: replace dead links in qunit fixture; use https
Ref jquerygh-5531
1 parent b4ab47a commit ed18576

File tree

8 files changed

+145
-145
lines changed

8 files changed

+145
-145
lines changed

test/data/qunit-fixture.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
<p id="firstp">See <a id="simon1" href="http://simon.incutio.com/archive/2003/03/25/#getElementsBySelector" rel="bookmark">this blog entry</a> for more information.</p>
1+
<p id="firstp">See <a id="john1" href="https://johnresig.com/blog/10th-anniversary-of-jquery/#body" rel="bookmark">this blog entry</a> for more information.</p>
22
<p id="ap">
3-
Here are some [links] in a normal paragraph: <a id="google" href="http://www.google.com/" title="Google!">Google</a>,
4-
<a id="groups" href="http://groups.google.com/" class="GROUPS">Google Groups (Link)</a>.
5-
This link has <code id="code1"><a href="http://smin" id="anchor1">class="blog"</a></code>:
6-
<a href="http://diveintomark.org/" class="blog" hreflang="en" id="mark">diveintomark</a>
3+
Here are some [links] in a normal paragraph: <a id="google" href="https://www.google.com/" title="Google!">Google</a>,
4+
<a id="groups" href="https://groups.google.com/" class="GROUPS">Google Groups (Link)</a>.
5+
This link has <code id="code1"><a href="https://blog" id="anchor1">class="blog"</a></code>:
6+
<a href="https://mozilla.org/" class="blog" hreflang="en" id="mozilla">mozilla</a>
77

88
</p>
99
<div id="foo">
1010
<p id="sndp">Everything inside the red border is inside a div with <code>id="foo"</code>.</p>
11-
<p lang="en" id="en">This is a normal link: <a id="yahoo" href="http://www.yahoo.com/" class="blogTest">Yahoo</a></p>
12-
<p id="sap">This link has <code><a href="#2" id="anchor2">class="blog"</a></code>: <a href="http://simon.incutio.com/" class="blog link" id="simon">Simon Willison's Weblog</a></p>
11+
<p lang="en" id="en">This is a normal link: <a id="yahoo" href="https://www.yahoo.com/" class="blogTest">Yahoo</a></p>
12+
<p id="sap">This link has <code><a href="#2" id="anchor2">class="blog"</a></code>: <a href="https://timmywil.com/" class="blog link" id="timmy">Timmy Willison's Weblog</a></p>
1313

1414
</div>
1515
<div id="nothiddendiv" style="height:1px;background:white;" class="nothiddendiv">

test/unit/attributes.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ QUnit.test( "attr(String)", function( assert ) {
6363
assert.equal( jQuery( "#text1" ).attr( "type" ), "text", "Check for type attribute" );
6464
assert.equal( jQuery( "#radio1" ).attr( "type" ), "radio", "Check for type attribute" );
6565
assert.equal( jQuery( "#check1" ).attr( "type" ), "checkbox", "Check for type attribute" );
66-
assert.equal( jQuery( "#simon1" ).attr( "rel" ), "bookmark", "Check for rel attribute" );
66+
assert.equal( jQuery( "#john1" ).attr( "rel" ), "bookmark", "Check for rel attribute" );
6767
assert.equal( jQuery( "#google" ).attr( "title" ), "Google!", "Check for title attribute" );
68-
assert.equal( jQuery( "#mark" ).attr( "hreflang" ), "en", "Check for hreflang attribute" );
68+
assert.equal( jQuery( "#mozilla" ).attr( "hreflang" ), "en", "Check for hreflang attribute" );
6969
assert.equal( jQuery( "#en" ).attr( "lang" ), "en", "Check for lang attribute" );
70-
assert.equal( jQuery( "#simon" ).attr( "class" ), "blog link", "Check for class attribute" );
70+
assert.equal( jQuery( "#timmy" ).attr( "class" ), "blog link", "Check for class attribute" );
7171
assert.equal( jQuery( "#name" ).attr( "name" ), "name", "Check for name attribute" );
7272
assert.equal( jQuery( "#text1" ).attr( "name" ), "action", "Check for name attribute" );
7373
assert.ok( jQuery( "#form" ).attr( "action" ).indexOf( "formaction" ) >= 0, "Check for action attribute" );

test/unit/core.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -589,14 +589,14 @@ QUnit.test( "inArray()", function( assert ) {
589589
p: q( "firstp", "sap", "ap", "first" ),
590590
em: q( "siblingnext", "siblingfirst" ),
591591
div: q( "qunit-testrunner-toolbar", "nothiddendiv", "nothiddendivchild", "foo" ),
592-
a: q( "mark", "groups", "google", "simon1" ),
592+
a: q( "mozilla", "groups", "google", "john1" ),
593593
empty: []
594594
},
595595
tests = {
596596
p: { elem: jQuery( "#ap" )[ 0 ], index: 2 },
597597
em: { elem: jQuery( "#siblingfirst" )[ 0 ], index: 1 },
598598
div: { elem: jQuery( "#nothiddendiv" )[ 0 ], index: 1 },
599-
a: { elem: jQuery( "#simon1" )[ 0 ], index: 3 }
599+
a: { elem: jQuery( "#john1" )[ 0 ], index: 3 }
600600
},
601601
falseTests = {
602602
p: jQuery( "#liveSpan1" )[ 0 ],
@@ -654,13 +654,13 @@ QUnit.test( "slice()", function( assert ) {
654654
var $links = jQuery( "#ap a" );
655655

656656
assert.deepEqual( $links.slice( 1, 2 ).get(), q( "groups" ), "slice(1,2)" );
657-
assert.deepEqual( $links.slice( 1 ).get(), q( "groups", "anchor1", "mark" ), "slice(1)" );
657+
assert.deepEqual( $links.slice( 1 ).get(), q( "groups", "anchor1", "mozilla" ), "slice(1)" );
658658
assert.deepEqual( $links.slice( 0, 3 ).get(), q( "google", "groups", "anchor1" ), "slice(0,3)" );
659-
assert.deepEqual( $links.slice( -1 ).get(), q( "mark" ), "slice(-1)" );
659+
assert.deepEqual( $links.slice( -1 ).get(), q( "mozilla" ), "slice(-1)" );
660660

661661
assert.deepEqual( $links.eq( 1 ).get(), q( "groups" ), "eq(1)" );
662662
assert.deepEqual( $links.eq( "2" ).get(), q( "anchor1" ), "eq('2')" );
663-
assert.deepEqual( $links.eq( -1 ).get(), q( "mark" ), "eq(-1)" );
663+
assert.deepEqual( $links.eq( -1 ).get(), q( "mozilla" ), "eq(-1)" );
664664
} );
665665

666666
QUnit.test( "first()/last()", function( assert ) {
@@ -669,7 +669,7 @@ QUnit.test( "first()/last()", function( assert ) {
669669
var $links = jQuery( "#ap a" ), $none = jQuery( "asdf" );
670670

671671
assert.deepEqual( $links.first().get(), q( "google" ), "first()" );
672-
assert.deepEqual( $links.last().get(), q( "mark" ), "last()" );
672+
assert.deepEqual( $links.last().get(), q( "mozilla" ), "last()" );
673673

674674
assert.deepEqual( $none.first().get(), [], "first() none" );
675675
assert.deepEqual( $none.last().get(), [], "last() none" );
@@ -681,7 +681,7 @@ QUnit.test( "even()/odd()", function( assert ) {
681681
var $links = jQuery( "#ap a" ), $none = jQuery( "asdf" );
682682

683683
assert.deepEqual( $links.even().get(), q( "google", "anchor1" ), "even()" );
684-
assert.deepEqual( $links.odd().get(), q( "groups", "mark" ), "odd()" );
684+
assert.deepEqual( $links.odd().get(), q( "groups", "mozilla" ), "odd()" );
685685

686686
assert.deepEqual( $none.even().get(), [], "even() none" );
687687
assert.deepEqual( $none.odd().get(), [], "odd() none" );
@@ -694,7 +694,7 @@ QUnit.test( "map()", function( assert ) {
694694
jQuery( "#ap" ).map( function() {
695695
return jQuery( this ).find( "a" ).get();
696696
} ).get(),
697-
q( "google", "groups", "anchor1", "mark" ),
697+
q( "google", "groups", "anchor1", "mozilla" ),
698698
"Array Map"
699699
);
700700

test/unit/deprecated.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ QUnit.test( "trigger() shortcuts", function( assert ) {
9393
assert.equal( counter, 1, "Check that click, triggers onclick event handler also" );
9494

9595
clickCounter = 0;
96-
jQuery( "#simon1" )[ 0 ].onclick = function() {
96+
jQuery( "#john1" )[ 0 ].onclick = function() {
9797
clickCounter++;
9898
};
99-
jQuery( "#simon1" ).click();
99+
jQuery( "#john1" ).click();
100100
assert.equal( clickCounter, 1, "Check that click, triggers onclick event handler on an a tag also" );
101101
} );
102102

test/unit/effects.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1732,7 +1732,7 @@ QUnit.test( "hide, fadeOut and slideUp called on element width height and width
17321732
QUnit.test( "hide should not leave hidden inline elements visible (trac-14848)", function( assert ) {
17331733
assert.expect( 2 );
17341734

1735-
var el = jQuery( "#simon1" );
1735+
var el = jQuery( "#john1" );
17361736

17371737
el.hide( 1, function() {
17381738
assert.equal( el.css( "display" ), "none", "hidden" );

0 commit comments

Comments
 (0)