[typescript-angular] fix: update basePath initialization to use template variable (OpenAPITools#20816)

fixes OpenAPITools#20760

Author: daniel-sc

modules/openapi-generator/src/main/resources/typescript-angular/api.base.service.mustache

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { {{configurationClassName}} } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = '{{{basePath}}}';
     public defaultHeaders = new HttpHeaders();
     public configuration: {{configurationClassName}};
     public encoder: HttpParameterCodec;

modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/typescriptangular/TypeScriptAngularClientCodegenTest.java

@@ -415,4 +415,28 @@ public void testNoDuplicateAuthentication() throws IOException {
         final String fileContents = Files.readString(Paths.get(output + "/api/default.service.ts"));
         assertThat(fileContents).containsOnlyOnce("localVarHeaders = this.configuration.addCredentialToHeaders('OAuth2', 'Authorization', localVarHeaders, 'Bearer ');");
     }
+
+    @Test
+    public void testBasePath() throws IOException {
+        // GIVEN
+        final String specPath = "src/test/resources/3_0/typescript-angular/issue_20760.yaml";
+
+        File output = Files.createTempDirectory("test").toFile();
+        output.deleteOnExit();
+
+        // WHEN
+        final CodegenConfigurator configurator = new CodegenConfigurator()
+            .setGeneratorName("typescript-angular")
+            .setInputSpec(specPath)
+            .setOutputDir(output.getAbsolutePath().replace("\\", "/"));
+
+        final ClientOptInput clientOptInput = configurator.toClientOptInput();
+
+        Generator generator = new DefaultGenerator();
+        generator.opts(clientOptInput).generate();
+
+        // THEN
+        final String fileContents = Files.readString(Paths.get(output + "/api.base.service.ts"));
+        assertThat(fileContents).containsOnlyOnce("basePath = '/relative/url'");
+    }
 }

modules/openapi-generator/src/test/resources/3_0/typescript-angular/issue_20760.yaml

@@ -0,0 +1,15 @@
+openapi: 3.0.1
+info:
+  title: OpenAPI Petstore
+  description: "sample spec"
+  license:
+    name: Apache-2.0
+    url: https://www.apache.org/licenses/LICENSE-2.0.html
+  version: 1.0.0
+servers:
+  - url: /relative/url
+tags: []
+paths: {}
+components:
+  schemas: {}
+  securitySchemes: {}

samples/client/others/typescript-angular/builds/composed-schemas-tagged-unions/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://api.example.xyz/v1';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;

samples/client/others/typescript-angular/builds/composed-schemas/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://api.example.xyz/v1';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;

samples/client/petstore/typescript-angular-v12-oneOf/builds/default/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://localhost';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;

samples/client/petstore/typescript-angular-v12-provided-in-any/builds/default/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://petstore.swagger.io/v2';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;

samples/client/petstore/typescript-angular-v12-provided-in-root/builds/default/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://petstore.swagger.io/v2';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;

samples/client/petstore/typescript-angular-v12-provided-in-root/builds/with-npm/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://petstore.swagger.io/v2';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;

samples/client/petstore/typescript-angular-v13-oneOf/builds/default/api.base.service.ts

@@ -3,7 +3,7 @@ import { CustomHttpParameterCodec } from './encoder';
 import { Configuration } from './configuration';
 
 export class BaseService {
-    protected basePath = '';
+    protected basePath = 'http://localhost';
     public defaultHeaders = new HttpHeaders();
     public configuration: Configuration;
     public encoder: HttpParameterCodec;