Skip to content

Commit c811121

Browse files
authored
Ros2 fixes (#95)
* Get rid of tests_require build warning * Get rid of KeyboardInterrupt * Lint * Implement for other nodes
1 parent 5936e97 commit c811121

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

yolo_ros/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
maintainer_email="mgons@unileon.es",
1717
description="YOLO for ROS 2",
1818
license="GPL-3",
19-
tests_require=["pytest"],
19+
extras_require={"test": ["pytest"]},
2020
entry_points={
2121
"console_scripts": [
2222
"yolo_node = yolo_ros.yolo_node:main",

yolo_ros/yolo_ros/debug_node.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,8 @@ def main():
380380
node = DebugNode()
381381
node.trigger_configure()
382382
node.trigger_activate()
383-
rclpy.spin(node)
384-
node.destroy_node()
385-
rclpy.shutdown()
383+
384+
try:
385+
rclpy.spin(node)
386+
except KeyboardInterrupt:
387+
pass

yolo_ros/yolo_ros/detect_3d_node.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,8 @@ def main():
441441
node = Detect3DNode()
442442
node.trigger_configure()
443443
node.trigger_activate()
444-
rclpy.spin(node)
445-
node.destroy_node()
446-
rclpy.shutdown()
444+
445+
try:
446+
rclpy.spin(node)
447+
except KeyboardInterrupt:
448+
pass

yolo_ros/yolo_ros/tracking_node.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,8 @@ def main():
203203
node = TrackingNode()
204204
node.trigger_configure()
205205
node.trigger_activate()
206-
rclpy.spin(node)
207-
node.destroy_node()
208-
rclpy.shutdown()
206+
207+
try:
208+
rclpy.spin(node)
209+
except KeyboardInterrupt:
210+
pass

yolo_ros/yolo_ros/yolo_node.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,8 @@ def main():
403403
node = YoloNode()
404404
node.trigger_configure()
405405
node.trigger_activate()
406-
rclpy.spin(node)
407-
node.destroy_node()
408-
rclpy.shutdown()
406+
407+
try:
408+
rclpy.spin(node)
409+
except KeyboardInterrupt:
410+
pass

0 commit comments

Comments
 (0)