Merge pull request #139 from mgriffin/no-500

Make sure newly registered users don't get 500 errors

Author: mgriffin

app/controllers/application_controller.rb

@@ -19,6 +19,6 @@ def admin_only!
   protected
 
   def configure_permitted_parameters
-    devise_parameter_sanitizer.permit(:sign_up, keys: [person_attributes: %i[firstname surname]])
+    devise_parameter_sanitizer.permit(:sign_up, keys: [:username])
   end
 end

app/models/user.rb

@@ -12,6 +12,8 @@ class User < ApplicationRecord
 
   delegate :teams, to: :person
 
+  before_create :find_or_create_person
+
   def name
     person&.fullname
   end
@@ -31,4 +33,13 @@ def committee?
   def thredded_admin?
     admin?
   end
+
+  private
+
+  def find_or_create_person
+    firstname, surname = username.split
+    surname = "" if surname.nil?
+
+    self.person = Person.find_or_create_by(firstname:, surname:)
+  end
 end

app/views/devise/registrations/new.html.erb

@@ -11,7 +11,7 @@
 
   <div class="mb-3">
     <%= f.label :username, class: "form-label" %>
-    <%= f.email_field :username, required: true, autocomplete: "username", placeholder: "Your name", class: "form-control" %>
+    <%= f.text_field :username, required: true, autocomplete: "username", placeholder: "Your name", class: "form-control" %>
   </div>
 
   <div class="mb-3">