Skip to content

Commit 6bc4166

Browse files
committed
fix(lighthouse-report): add support of playwright-lighthouse 3.2.5
1 parent 3e0b4c6 commit 6bc4166

File tree

4 files changed

+1398
-1894
lines changed

4 files changed

+1398
-1894
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ lighthousePages.forEach(({ name, po, thresholds, swimlanes }) => {
4747
// to let playwright initialize context!
4848
context // this is enough to make the test work
4949

50+
// note: importing LighthouseResult is not needed since playwright-lighthouse release after v3.2.5 (not including)
5051
const result: LighthouseResult = await playAudit({
5152
url: baseURL + po.getPath('123'),
5253
port,
@@ -140,6 +141,7 @@ const runLighthouse = async (story: StorybookIndexStory, context: BrowserContext
140141
// const page = context.pages()[0]
141142
// await page.goto(`/iframe.html?id=${story.id}`)
142143

144+
// note: importing LighthouseResult is not needed since playwright-lighthouse release after v3.2.5 (not including)
143145
const result: LighthouseResult = await playAudit({
144146
url: baseURL + `/iframe.html?id=${story.id}`,
145147
// page, // alternatevely, path the page instead of the `url`

0 commit comments

Comments
 (0)