Skip to content

Commit 1995fe4

Browse files
authored
5m CI speedup per Test job: Stop manually installing VS Components (#2692)
1 parent d32028e commit 1995fe4

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/install-vs-components.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# See https://github.com/actions/runner-images/issues/9701
22
# Adapted from https://github.com/actions/runner-images/issues/9873#issuecomment-2139288682
33

4+
# NOTE: This isn't currently needed, but script is kept in case Microsoft breaks GitHub-hosted runners for us again
5+
46
import os
57
import platform
68
from itertools import chain

.github/workflows/main.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
test:
1717
name: Build and test
1818
runs-on: ${{ matrix.os }}
19-
timeout-minutes: 30
19+
timeout-minutes: &timeout-minutes 25
2020
strategy:
2121
fail-fast: false
2222
matrix:
@@ -72,9 +72,6 @@ jobs:
7272
- name: Add msbuild to PATH
7373
uses: microsoft/setup-msbuild@v2
7474

75-
- name: Install missing Visual Studio components
76-
run: python .github\workflows\install-vs-components.py
77-
7875
- name: Build and register the PyCOMTest server dll
7976
# Pass Silent flag to regsvr32 to avoid hanging on confirmation window
8077
run: com/TestSources/PyCOMTest/buildAndRegister.bat /s
@@ -99,7 +96,7 @@ jobs:
9996
cross_compile_arm64:
10097
name: Cross-compile ARM64
10198
runs-on: windows-2022
102-
timeout-minutes: 30
99+
timeout-minutes: *timeout-minutes
103100
strategy:
104101
fail-fast: false
105102
matrix:
@@ -143,7 +140,7 @@ jobs:
143140
# This job can be run locally by running `pre-commit run`
144141
checkers:
145142
runs-on: ubuntu-latest
146-
timeout-minutes: 30
143+
timeout-minutes: *timeout-minutes
147144
steps:
148145
- uses: actions/checkout@v4
149146
- uses: astral-sh/setup-uv@v7
@@ -177,7 +174,7 @@ jobs:
177174
178175
type-checkers:
179176
runs-on: ubuntu-latest
180-
timeout-minutes: 30
177+
timeout-minutes: *timeout-minutes
181178
strategy:
182179
fail-fast: false
183180
matrix:

0 commit comments

Comments
 (0)