Skip to content

Commit a37b9c5

Browse files
committed
run CI checkers on Ubuntu
1 parent dd2b536 commit a37b9c5

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@
22
AutoDuck/*.fmt text eol=crlf
33
*.dsp text eol=crlf
44
*.dsw text eol=crlf
5+
*.py text eol=crlf

.github/workflows/main.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ jobs:
127127
if-no-files-found: error
128128

129129
merge:
130-
runs-on: windows-latest
130+
runs-on: ubuntu-latest
131131
needs: [test, build_arm64]
132132
steps:
133133
- name: Merge Artifacts
@@ -142,7 +142,7 @@ jobs:
142142

143143
# This job can be run locally by running `pre-commit run`
144144
checkers:
145-
runs-on: windows-2022
145+
runs-on: ubuntu-latest
146146
timeout-minutes: 30
147147
steps:
148148
- uses: actions/checkout@v4
@@ -167,14 +167,16 @@ jobs:
167167
- run: |
168168
clang-format --Werror --dry-run $(git ls-files '*.cpp' ':!:com/win32comext/mapi/src/MAPIStubLibrary/')
169169
if ($LastExitCode -ne 0) { exit $LastExitCode }
170+
shell: pwsh
170171
if: ${{ !cancelled() }}
171172
- run: |
172173
clang-format --Werror --dry-run $(git ls-files '*.h' ':!:Pythonwin/Scintilla/' ':!:com/win32comext/mapi/src/MAPIStubLibrary/')
173174
if ($LastExitCode -ne 0) { exit $LastExitCode }
175+
shell: pwsh
174176
if: ${{ !cancelled() }}
175177
176178
type-checkers:
177-
runs-on: windows-2022
179+
runs-on: ubuntu-latest
178180
timeout-minutes: 30
179181
strategy:
180182
fail-fast: false

mypy.ini

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
[mypy]
22
show_column_numbers = true
3+
; Needs to be set for non-Windows CI runners
4+
platform = win32
35
; Target the oldest supported version in editors and default CLI
46
python_version = 3.8
57

pyrightconfig.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
{
22
"typeCheckingMode": "basic",
3+
// Needs to be set for non-Windows CI runners
4+
"pythonPlatform": "Windows",
35
// Target the oldest supported version in editors and default CLI
46
"pythonVersion": "3.9",
57
// Keep it simple for now by allowing both mypy and pyright to use `type: ignore`
68
"enableTypeIgnoreComments": true,
79
// Exclude from scanning when running pyright
810
"exclude": [
911
".git/", // Avoids scanning git branch names ending in ".py"
12+
".venv/",
1013
"build/",
1114
// Vendored
1215
"Pythonwin/Scintilla/",
@@ -16,6 +19,7 @@
1619
"**/Test/",
1720
"**/test/",
1821
"**/Demos/",
22+
"**/demos/",
1923
"**/demo/",
2024
],
2125
// Packages that will be accessible globally.

0 commit comments

Comments
 (0)