pycln: cleanup imports not in known-side effects list (#2402)

Avasam · web-flow · commit cf8d98591f42 · 2025-01-04T18:18:24.000-05:00
diff --git a/Pythonwin/pywin/Demos/ocx/ocxserialtest.py b/Pythonwin/pywin/Demos/ocx/ocxserialtest.py
@@ -8,7 +8,6 @@
 import pythoncom
 import win32con
 import win32ui
-import win32uiole
 from pywin.mfc import activex, dialog
 from win32com.client import gencache
 
diff --git a/Pythonwin/pywin/Demos/ocx/ocxtest.py b/Pythonwin/pywin/Demos/ocx/ocxtest.py
@@ -11,7 +11,6 @@
 import win32api
 import win32con
 import win32ui
-import win32uiole
 from pywin.mfc import activex, dialog, window
 from win32com.client import gencache
 
diff --git a/Pythonwin/pywin/Demos/toolbar.py b/Pythonwin/pywin/Demos/toolbar.py
@@ -4,7 +4,6 @@
 # Demos how to make custom tooltips, etc.
 
 import commctrl
-import win32api
 import win32con
 import win32ui
 from pywin.mfc import afxres, docview, window
diff --git a/Pythonwin/pywin/debugger/dbgcon.py b/Pythonwin/pywin/debugger/dbgcon.py
@@ -12,7 +12,6 @@
 OPT_HIDE = "hide"
 OPT_STOP_EXCEPTIONS = "stopatexceptions"
 
-import win32api
 import win32ui
 
 
diff --git a/Pythonwin/pywin/dialogs/login.py b/Pythonwin/pywin/dialogs/login.py
@@ -23,7 +23,6 @@
 Merged with dlgpass and moved to pywin.dialogs by Mark Hammond Jan 1998.
 """
 
-import win32api
 import win32con
 import win32ui
 from pywin.mfc import dialog
diff --git a/Pythonwin/pywin/framework/intpydde.py b/Pythonwin/pywin/framework/intpydde.py
@@ -8,7 +8,6 @@
 import sys
 import traceback
 
-import win32api
 import win32ui
 from dde import (  # nopycln: import # Re-exported for intpyapp.py
     CBF_FAIL_SELFCONNECTIONS as CBF_FAIL_SELFCONNECTIONS,  # noqa: PLC0414
diff --git a/com/win32com/test/testPyComTest.py b/com/win32com/test/testPyComTest.py
@@ -11,7 +11,6 @@
 
 import pythoncom
 import pywintypes
-import win32api
 import win32com
 import win32com.client.connect
 import win32com.test.util
diff --git a/com/win32com/test/testmakepy.py b/com/win32com/test/testmakepy.py
@@ -4,7 +4,6 @@
 import traceback
 
 import pythoncom
-import win32api
 import win32com.test.util
 import winerror
 from win32com.client import gencache, makepy, selecttlb
diff --git a/com/win32comext/adsi/demos/search.py b/com/win32comext/adsi/demos/search.py
@@ -1,6 +1,5 @@
 import pythoncom
 import pywintypes
-import win32security
 from win32com.adsi import adsi, adsicon
 from win32com.adsi.adsicon import *
 
diff --git a/com/win32comext/authorization/demos/EditServiceSecurity.py b/com/win32comext/authorization/demos/EditServiceSecurity.py
@@ -7,7 +7,6 @@
 import os
 
 import pythoncom
-import win32api
 import win32com.server.policy
 import win32con
 import win32security
diff --git a/com/win32comext/axscript/client/pyscript.py b/com/win32comext/axscript/client/pyscript.py
@@ -11,7 +11,6 @@
 import types
 
 import pythoncom
-import win32api
 import win32com
 import win32com.client.dynamic
 import win32com.server.register
diff --git a/com/win32comext/shell/demos/servers/icon_handler.py b/com/win32comext/shell/demos/servers/icon_handler.py
@@ -13,7 +13,6 @@
 import sys
 
 import pythoncom
-import win32gui
 import winerror
 from win32com.shell import shell
 
diff --git a/com/win32comext/taskscheduler/test/test_addtask_2.py b/com/win32comext/taskscheduler/test/test_addtask_2.py
@@ -1,7 +1,6 @@
 import time
 
 import pythoncom
-import win32api
 from win32com.taskscheduler import taskscheduler
 
 task_name = "test_addtask_2.job"
diff --git a/pycln.toml b/pycln.toml
@@ -1,18 +1,6 @@
 [tool.pycln]
-# Many imports with side-effects
 all = true
 skip_imports = [
-  # TODO: Confirm whether these produce side-effects,
-  # if yes: add to the list below
-  # if not: remove from here
-  # NOTE: https://github.com/mhammond/pywin32/pull/2342#discussion_r1798419855
-  # It seems we should be able to remove these. TODO in its own PR.
-  "win32api",
-  "win32file",
-  "win32gui",
-  "win32process",
-  "win32security",
-  "win32uiole",
   # Modules with known side-effects
   "coloreditor", # Adds doc template
   "IDLEenvironment", # Injects fast_readline into the IDLE auto-indent extension
diff --git a/win32/Demos/security/account_rights.py b/win32/Demos/security/account_rights.py
@@ -1,7 +1,6 @@
 import ntsecuritycon
 import win32api
 import win32con
-import win32file
 import win32security
 
 new_privs = (
diff --git a/win32/Demos/security/explicit_entries.py b/win32/Demos/security/explicit_entries.py
@@ -3,7 +3,6 @@
 import ntsecuritycon
 import win32api
 import win32con
-import win32file
 import win32security
 from security_enums import ACCESS_MODE, ACE_FLAGS, TRUSTEE_FORM, TRUSTEE_TYPE
 
diff --git a/win32/Demos/security/get_policy_info.py b/win32/Demos/security/get_policy_info.py
@@ -1,5 +1,3 @@
-import win32api
-import win32file
 import win32security
 
 policy_handle = win32security.GetPolicyHandle("rupole", win32security.POLICY_ALL_ACCESS)
diff --git a/win32/Demos/security/list_rights.py b/win32/Demos/security/list_rights.py
@@ -1,7 +1,6 @@
 import ntsecuritycon
 import win32api
 import win32con
-import win32file
 import win32security
 
 new_privs = (
diff --git a/win32/Demos/security/set_file_audit.py b/win32/Demos/security/set_file_audit.py
@@ -3,7 +3,6 @@
 import ntsecuritycon
 import win32api
 import win32con
-import win32file
 import win32security
 from win32security import (
     ACL_REVISION_DS,
diff --git a/win32/Demos/security/set_file_owner.py b/win32/Demos/security/set_file_owner.py
@@ -3,7 +3,6 @@
 import ntsecuritycon
 import win32api
 import win32con
-import win32file
 import win32security
 
 new_privs = (
diff --git a/win32/Demos/security/set_policy_info.py b/win32/Demos/security/set_policy_info.py
@@ -1,5 +1,3 @@
-import win32api
-import win32file
 import win32security
 
 policy_handle = win32security.GetPolicyHandle("rupole", win32security.POLICY_ALL_ACCESS)
diff --git a/win32/Demos/security/setkernelobjectsecurity.py b/win32/Demos/security/setkernelobjectsecurity.py
@@ -1,6 +1,5 @@
 import win32api
 import win32con
-import win32process
 import win32security
 
 ## You need SE_RESTORE_NAME to be able to set the owner of a security descriptor to anybody
diff --git a/win32/Demos/security/setsecurityinfo.py b/win32/Demos/security/setsecurityinfo.py
@@ -1,6 +1,5 @@
 import win32api
 import win32con
-import win32process
 import win32security
 
 ## You need SE_RESTORE_NAME to be able to set the owner of a security descriptor to anybody
diff --git a/win32/Demos/security/setuserobjectsecurity.py b/win32/Demos/security/setuserobjectsecurity.py
@@ -1,4 +1,3 @@
-import win32api
 import win32con
 import win32process
 import win32security
diff --git a/win32/Demos/security/sspi/socket_server.py b/win32/Demos/security/sspi/socket_server.py
@@ -27,7 +27,6 @@
 
 import sspi
 import win32api
-import win32security
 
 options = None  # set to optparse object.
 
diff --git a/win32/Demos/win32gui_devicenotify.py b/win32/Demos/win32gui_devicenotify.py
@@ -4,7 +4,6 @@
 import sys
 import time
 
-import win32api
 import win32con
 import win32file
 import win32gui
diff --git a/win32/test/test_win32guistruct.py b/win32/test/test_win32guistruct.py
@@ -3,7 +3,6 @@
 
 import pythoncom
 import win32con
-import win32gui
 import win32gui_struct
 
 
diff --git a/win32/winxpgui.py b/win32/winxpgui.py
@@ -8,6 +8,6 @@
 from win32console import (  # nopycln: import
     GetConsoleWindow as GetConsoleWindow,  # noqa: PLC0414 # Explicit re-export
 )
-from win32gui import *
+from win32gui import *  # nopycln: import
 
 warnings.warn(str(__doc__), category=DeprecationWarning)
