close file handle in cancellation handler as documented to avoid race condition (pointfreeco#174)

KaiOelfke · mhayes853 · commit dc1e77e8b8fd · 2025-08-11T21:24:05.000-07:00
diff --git a/Sources/Sharing/SharedKeys/FileStorageKey.swift b/Sources/Sharing/SharedKeys/FileStorageKey.swift
@@ -352,10 +352,12 @@
           queue: DispatchQueue.main
         )
         source.setEventHandler(handler: $2)
+        source.setCancelHandler {
+          close(source.handle)
+        }
         source.resume()
         return SharedSubscription {
           source.cancel()
-          close(source.handle)
         }
       },
       load: { url in

Original file line number	Diff line number	Diff line change
`@@ -352,10 +352,12 @@`
`352`	`352`	`queue: DispatchQueue.main`
`353`	`353`	`)`
`354`	`354`	`source.setEventHandler(handler: $2)`
	`355`	`+ source.setCancelHandler {`
	`356`	`+ close(source.handle)`
	`357`	`+ }`
`355`	`358`	`source.resume()`
`356`	`359`	`return SharedSubscription {`
`357`	`360`	`source.cancel()`
`358`		`- close(source.handle)`
`359`	`361`	`}`
`360`	`362`	`},`
`361`	`363`	`load: { url in`