Only attempt to retry sending an extension life cycle event (install / update) once per release, when the first attempt failed.

Author: mhutchie

src/life-cycle/startup.ts

@@ -50,7 +50,8 @@ export async function onStartUp(extensionContext: vscode.ExtensionContext) {
 					extension: versions.extension,
 					vscode: versions.vscode,
 					nonce: nonce
-				}]
+				}],
+				attempts: 1
 			};
 		} else {
 			// Update
@@ -62,15 +63,18 @@ export async function onStartUp(extensionContext: vscode.ExtensionContext) {
 				to: state.current,
 				nonce: nonce
 			});
+			state.attempts = 1;
 		}
 
 		await saveLifeCycleState(extensionContext, state);
 		state.apiAvailable = await sendQueue(state.queue);
 		state.queue = [];
 		await saveLifeCycleState(extensionContext, state);
 
-	} else if (state.queue.length > 0) {
+	} else if (state.queue.length > 0 && state.attempts < 2) {
 		// There are one or more events in the queue that previously failed to send, send them
+		state.attempts++;
+		await saveLifeCycleState(extensionContext, state);
 		state.apiAvailable = await sendQueue(state.queue);
 		state.queue = [];
 		await saveLifeCycleState(extensionContext, state);

src/life-cycle/utils.ts

@@ -52,6 +52,7 @@ export interface LifeCycleState {
 	};
 	apiAvailable: boolean;
 	queue: LifeCycleEvent[];
+	attempts: number;
 }
 
 /**
@@ -91,7 +92,7 @@ export function getLifeCycleStateInDirectory(directory: string) {
 				resolve(null);
 			} else {
 				try {
-					resolve(JSON.parse(data.toString()));
+					resolve(Object.assign({ attempts: 1 }, JSON.parse(data.toString())));
 				} catch (_) {
 					resolve(null);
 				}