Skip to content

Commit 55bcfa0

Browse files
the-mikedavismi2ebi
authored andcommitted
Avoid cloning language server names in Document::save
`language_servers` is a `HashMap<String, Arc<Client>>` so the clients are cheap to clone but not the language server names. The names are unused in the save future so we can avoid the unnecessary clones by looking only at the `HashMap::values`.
1 parent c4778ee commit 55bcfa0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

helix-view/src/document.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,7 @@ impl Document {
980980
};
981981

982982
let identifier = self.path().map(|_| self.identifier());
983-
let language_servers = self.language_servers.clone();
983+
let language_servers: Vec<_> = self.language_servers.values().cloned().collect();
984984

985985
// mark changes up to now as saved
986986
let current_rev = self.get_current_revision();
@@ -1124,7 +1124,7 @@ impl Document {
11241124
text: text.clone(),
11251125
};
11261126

1127-
for (_, language_server) in language_servers {
1127+
for language_server in language_servers {
11281128
if !language_server.is_initialized() {
11291129
continue;
11301130
}

0 commit comments

Comments
 (0)