Add retry logic for bad gateway response errors (#149)

Author: tr4nt0r

bring_api/bring.py

@@ -7,6 +7,7 @@
 from json import JSONDecodeError
 import logging
 import os
+from random import randint
 import time
 from typing import TYPE_CHECKING, Any
 
@@ -144,6 +145,18 @@ async def _request(
                     "the authorization token is invalid or expired."
                 )
 
+            if (
+                r.status
+                in (
+                    HTTPStatus.BAD_GATEWAY,
+                    HTTPStatus.SERVICE_UNAVAILABLE,
+                    HTTPStatus.GATEWAY_TIMEOUT,
+                )
+                and not retry
+            ):
+                await asyncio.sleep(delay=randint(1, 5000) / 1000)
+                return await self._request(method, url, retry=True, **kwargs)
+
             r.raise_for_status()
 
         except aiohttp.ClientResponseError as e:

tests/test_request.py

@@ -2,6 +2,7 @@
 
 import asyncio
 from http import HTTPStatus
+from unittest.mock import patch
 
 import aiohttp
 from aioresponses import aioresponses
@@ -88,3 +89,30 @@ async def test_auth_expired(
         method="get",
         headers=DEFAULT_HEADERS,
     )
+
+
+async def test_bad_gateway_retry(mocked: aioresponses, bring: Bring) -> None:
+    """Test retry logic for bad gateway errors."""
+
+    await bring.login()
+    mocked.clear()
+
+    mocked.get(
+        URL("https://api.getbring.com/test"),
+        status=HTTPStatus.BAD_GATEWAY,
+    )
+    mocked.get(
+        URL("https://api.getbring.com/test"),
+        status=HTTPStatus.OK,
+    )
+
+    with patch("bring_api.bring.randint", return_value=0):
+        await bring._request("GET", URL("https://api.getbring.com/test"))
+
+    mocked.assert_called_with(
+        "https://api.getbring.com/test",
+        method="get",
+        headers=DEFAULT_HEADERS,
+    )
+
+    assert len(mocked._responses) == 2