- remove redundant using statements

- remove redundant qualifiers
- add missing asserts

Author: michael-damatov

Sources/LambdaConverters.Wpf/MultiValueConverter.cs

@@ -175,6 +175,8 @@ protected override object ConvertInternal(object[] values, object parameter, Cul
                     }
                 }
 
+                Debug.Assert(convertFunction != null);
+
                 return convertFunction(new MultiValueConverterArgs<I>(new ReadOnlyCollection<I>(inputValues), culture));
             }
 
@@ -257,6 +259,8 @@ protected override object ConvertInternal(object[] values, object parameter, Cul
                     }
                 }
 
+                Debug.Assert(convertFunction != null);
+
                 return convertFunction(new MultiValueConverterArgs<I, P>(new ReadOnlyCollection<I>(inputValues), parameterValue, culture));
             }
 

Sources/LambdaConverters.Wpf/Properties/AssemblyInfo.cs

@@ -1,15 +1,15 @@
 using System.Reflection;
 using System.Runtime.InteropServices;
 
-// General Information about an assembly is controlled through the following 
+// General Information about an assembly is controlled through the following
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: AssemblyCopyright("© 2017 Michael Damatov, Dimitri Enns.")]
 
-// Setting ComVisible to false makes the types in this assembly not visible 
-// to COM components.  If you need to access a type in this assembly from 
+// Setting ComVisible to false makes the types in this assembly not visible
+// to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.
 [assembly: ComVisible(false)]
 

Sources/LambdaConverters.Wpf/RuleErrorStrategy.cs

@@ -1,6 +1,4 @@
-using System.Windows.Controls;
-
-namespace LambdaConverters
+namespace LambdaConverters
 {
     /// <summary>
     /// Defines the validation rule error strategy.

Sources/LambdaConverters.Wpf/TemplateSelector.cs

@@ -11,7 +11,7 @@ namespace LambdaConverters
     /// </summary>
     public static class TemplateSelector
     {
-        sealed class Selector<I> : System.Windows.Controls.DataTemplateSelector
+        sealed class Selector<I> : DataTemplateSelector
         {
             readonly Func<TemplateSelectorArgs<I>, DataTemplate> selectFunction;
 
@@ -63,7 +63,7 @@ DataTemplate SelectTemplateInternal(object item, DependencyObject container)
 
             public override DataTemplate SelectTemplate(object item, DependencyObject container)
             {
-                if (this.selectFunction == null)
+                if (selectFunction == null)
                 {
                     EventSource.Log.MissingSelectTemplateFunction("selectFunction", ErrorStrategy.ToString());
 

Sources/LambdaConverters.Wpf/Validator.cs

@@ -11,7 +11,7 @@ namespace LambdaConverters
     /// </summary>
     public static class Validator
     {
-        sealed class Rule<I> : System.Windows.Controls.ValidationRule
+        sealed class Rule<I> : ValidationRule
         {
             readonly Func<ValidationRuleArgs<I>, ValidationResult> ruleFunction;
 
@@ -65,7 +65,7 @@ ValidationResult ValidateInternal(object item, CultureInfo cultureInfo)
 
             public override ValidationResult Validate(object value, CultureInfo cultureInfo)
             {
-                if (this.ruleFunction == null)
+                if (ruleFunction == null)
                 {
                     EventSource.Log.MissingRuleFunction("ruleFunction", ErrorStrategy.ToString());
 

Sources/Tests.LambdaConverters.Wpf/Properties/AssemblyInfo.cs

@@ -1,20 +1,20 @@
 using System.Reflection;
 using System.Runtime.InteropServices;
 
-// General Information about an assembly is controlled through the following 
+// General Information about an assembly is controlled through the following
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("Tests.LambdaConverters.Wpf")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]
 [assembly: AssemblyProduct("Tests.LambdaConverters.Wpf")]
-[assembly: AssemblyCopyright("Copyright ©  2016")]
+[assembly: AssemblyCopyright("")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
-// Setting ComVisible to false makes the types in this assembly not visible 
-// to COM components.  If you need to access a type in this assembly from 
+// Setting ComVisible to false makes the types in this assembly not visible
+// to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.
 [assembly: ComVisible(false)]
 
@@ -24,11 +24,11 @@
 // Version information for an assembly consists of the following four values:
 //
 //      Major Version
-//      Minor Version 
+//      Minor Version
 //      Build Number
 //      Revision
 //
-// You can specify all the values or you can default the Build and Revision Numbers 
+// You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion("1.0.0.0")]

Sources/Tests.Shared/SequenceAssert.cs

@@ -71,8 +71,7 @@ public static void DoesNotContain<T>([NotNull] IEnumerable<T> sequence, T item,
 
         public static void AreEqual<T>(IEnumerable<T> expected, IEnumerable<T> actual, Func<T, T, bool> equalityComparer = null)
         {
-            string reason;
-            if (!AreEqual(expected, actual, equalityComparer, out reason))
+            if (!AreEqual(expected, actual, equalityComparer, out var reason))
             {
                 throw new AssertFailedException(string.Format("{0} failed. {1}", nameof(AreEqual), reason));
             }