Start of v2.x branch.

Author: michaeldrennen

README.md

@@ -1,4 +1,4 @@
-# LocalFile
+# LocalFile v2.x
 [![Latest Stable Version](https://poser.pugx.org/michaeldrennen/local-file/version)](https://packagist.org/packages/michaeldrennen/local-file) [![Total Downloads](https://poser.pugx.org/michaeldrennen/local-file/downloads)](https://packagist.org/packages/michaeldrennen/local-file) [![License](https://poser.pugx.org/michaeldrennen/local-file/license)](https://packagist.org/packages/michaeldrennen/local-file) [![Build Status](https://travis-ci.org/michaeldrennen/LocalFile.svg?branch=v1.0.2)](https://travis-ci.org/michaeldrennen/LocalFile) [![Coverage Status](https://coveralls.io/repos/github/michaeldrennen/LocalFile/badge.svg?branch=master)](https://coveralls.io/github/michaeldrennen/LocalFile?branch=master)
 
 A small php library that handles some common functions needed for local files.

composer.json

@@ -2,10 +2,14 @@
   "name": "michaeldrennen/local-file",
   "description": "A small php library that adds some functions to operate on local files, like an efficient line count function.",
   "type": "library",
+  "require": {
+    "php": "^7.3"
+  },
   "require-dev": {
-    "satooshi/php-coveralls": "^2.0",
-    "phpunit/phpunit": "^6.5",
-    "mikey179/vfsStream": "^1.6"
+    "mikey179/vfsstream": "dev-master",
+    "phpunit/phpunit": "^8.0",
+    "php-coveralls/php-coveralls": "^2.1"
+
   },
   "license": "MIT",
   "authors": [
@@ -24,8 +28,5 @@
     "psr-4": {
       "MichaelDrenen\\LocalFile\\Tests\\": "tests"
     }
-  },
-  "require": {
-    "php": "^7.1"
   }
 }

phpunit.xml

@@ -7,9 +7,7 @@
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
          processIsolation="false"
-         stopOnFailure="false"
-         syntaxCheck="false"
->
+         stopOnFailure="false">
     <testsuites>
         <testsuite name="LocalFile Test Suite">
             <directory suffix=".php">./tests/</directory>
@@ -25,8 +23,6 @@
     <logging>
         <log type="coverage-html"
              target="./build/coverage/html"
-             charset="UTF-8"
-             highlight="false"
              lowUpperBound="35"
              highLowerBound="70"/>
         <log type="coverage-clover" target="build/logs/clover.xml"/>

tests/SplitTest.php

@@ -11,8 +11,7 @@
 use PHPUnit\Framework\TestCase;
 use MichaelDrennen\LocalFile\LocalFile;
 
-class SplitTest extends TestCase
-{
+class SplitTest extends TestCase {
 
     const VFS_ROOT_DIR = 'vfsRootDir';
     const WRITEABLE_DIR_NAME = 'writeableDir';
@@ -57,9 +56,8 @@ class SplitTest extends TestCase
     /**
      * Set up test environment
      */
-    public function setUp()
-    {
-        self::$vfsRootDirObject = vfsStream::setup(self::VFS_ROOT_DIR);
+    public function setUp(): void {
+        self::$vfsRootDirObject   = vfsStream::setup(self::VFS_ROOT_DIR);
         self::$writeableDirectory = vfsStream::url(self::VFS_ROOT_DIR . DIRECTORY_SEPARATOR . self::WRITEABLE_DIR_NAME);
         mkdir(self::$writeableDirectory, 0777);
         self::$anotherWriteableDirectory = vfsStream::url(self::VFS_ROOT_DIR . DIRECTORY_SEPARATOR . self::ANOTHER_WRITEABLE_DIR_NAME);
@@ -76,29 +74,25 @@ public function setUp()
     }
 
 
-    public function testSplitWithNonExistentFileShouldThrowException()
-    {
+    public function testSplitWithNonExistentFileShouldThrowException() {
         $this->expectException(SourceFileDoesNotExist::class);
         LocalFile::split(self::PATH_TO_NON_EXISTENT_FILE);
     }
 
-    public function testSplitWithUnreadableFileShouldThrowException()
-    {
+    public function testSplitWithUnreadableFileShouldThrowException() {
         $this->expectException(UnableToReadFile::class);
         LocalFile::split(self::$unreadableSourceFilePath);
     }
 
-    public function testSplitIntoReadOnlyDirectoryShouldThrowException()
-    {
+    public function testSplitIntoReadOnlyDirectoryShouldThrowException() {
         $this->expectException(CantWriteToReadOnlyDirectory::class);
         LocalFile::split(self::PATH_TO_SOURCE_FILE, 1, 'split_', self::$readOnlyDirectory);
     }
 
     /**
      * @group quota
      */
-    public function testSplitIntoFullDiskShouldThrowException()
-    {
+    public function testSplitIntoFullDiskShouldThrowException() {
         $this->expectException(UnableToWriteLineToSplitFile::class);
         // Gives me enough room to write the source file.
         $bytesInSourceFile = filesize(self::PATH_TO_SOURCE_FILE);
@@ -114,8 +108,7 @@ public function testSplitIntoFullDiskShouldThrowException()
     }
 
 
-    public function testSplitShouldMakeFiveFilesInSameDirectory()
-    {
+    public function testSplitShouldMakeFiveFilesInSameDirectory() {
         LocalFile::split(self::$readableSourceFilePath, 4);
         $files = scandir(self::$writeableDirectory);
         $this->assertCount(9, $files); // includes . and ..
@@ -129,13 +122,12 @@ public function testSplitShouldMakeFiveFilesInSameDirectory()
      * @throws \MichaelDrennen\LocalFile\Exceptions\UnableToWriteLineToSplitFile
      * @group mike
      */
-    public function testSplitShouldMakeFiveFilesInAnotherDirectory()
-    {
+    public function testSplitShouldMakeFiveFilesInAnotherDirectory() {
         $expectedFinalFileCount = 5;
-        $linesPerFile = 4;
-        $virtualSourceFilePath = vfsStream::url(self::VFS_ROOT_DIR . DIRECTORY_SEPARATOR .
-            self::WRITEABLE_DIR_NAME . DIRECTORY_SEPARATOR .
-            self::SOURCE_FILE_NAME);
+        $linesPerFile           = 4;
+        $virtualSourceFilePath  = vfsStream::url(self::VFS_ROOT_DIR . DIRECTORY_SEPARATOR .
+                                                 self::WRITEABLE_DIR_NAME . DIRECTORY_SEPARATOR .
+                                                 self::SOURCE_FILE_NAME);
         file_put_contents($virtualSourceFilePath, file_get_contents(self::PATH_TO_SOURCE_FILE));
 
         LocalFile::split($virtualSourceFilePath, $linesPerFile, null, self::$anotherWriteableDirectory);