Let user decide which type to use for 'user_id' col

Author: michaeldzjap

src/config/twofactor-auth.php

@@ -64,4 +64,24 @@
         'post' => '/auth/token',
     ],
 
+    /*
+    |--------------------------------------------------------------------------
+    | Database Settings
+    |--------------------------------------------------------------------------
+    |
+    | Starting from Laravel 5.8, the default is to use "bigIncrements" instead
+    | of "increments" for the "id" column on the "users" table. This setting
+    | allows you to control what type to use for the "user_id" column on the
+    | "two_factor_auths" table. The default is to use "unsignedBigInteger" in
+    | order to stay in line with the changes in Laravel 5.8.
+    |
+    | NOTE: Modifying this setting only has an effect before you run any
+    | migrations for this package. If you need to change the signature of
+    | "user_id" afterwards, you will have to write your own migration for this
+    | (see install instructions for more details).
+    |
+    */
+
+    'big_int' => true,
+
 ];

src/database/migrations/2017_05_26_102832_create_two_factor_auths_table.php

@@ -17,10 +17,10 @@ public function up()
         Schema::create('two_factor_auths', function (Blueprint $table) {
             $table->string('id')->nullable();
 
-            if ($this->isUnsignedInteger()) {
-                $table->unsignedInteger('user_id');
-            } else {
+            if ($this->useBigInt()) {
                 $table->unsignedBigInteger('user_id');
+            } else {
+                $table->unsignedInteger('user_id');
             }
 
             $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade');
@@ -39,33 +39,13 @@ public function down()
     }
 
     /**
-     * Determine if the column type for "user_id" should be of type "unsignedInteger"
-     * using the type of "id" on "users" as a reference.
-     *
-     * Why do we do this?
-     *
-     * Laravel 5.8 changed the type of "id" on "users" from "increments"
-     * to "bigIncrements". Hence, we potentially could run into trouble if we
-     * don't support the following two potential scenarios
-     *
-     * 1. We update from 5.7 to 5.8, but decide to keep using "increments"
-     * 2. We start a fresh Laravel project which uses "bigIncrements" by default
-     *
-     * The only way to account for both scenarios in a reliable way is to check
-     * the type of "id" on "users" before we create our foreign key.
-     *
-     * Why is this not ideal?
-     *
-     * 1. There now is a dependency on doctrine/dbal
-     * 2. We now have to use conditional logic in our migration file
+     * Determine if the type of the "user_id" column should be of type
+     * "unsignedBigInteger".
      *
      * @return bool
      */
-    private function isUnsignedInteger()
+    private function useBigInt()
     {
-        return DB::getDoctrineSchemaManager()
-            ->listTableDetails('users')
-            ->getColumn('id')
-            ->getType() instanceof \Doctrine\DBAL\Types\IntegerType;
+        return config('twofactor-auth.big_int');
     }
 }