Skip to content

Commit c86fe78

Browse files
authored
Remove the Gate knob from effects (LMMS#8011)
Major changes: - Remove Gate knob from effects, effectively hard coding its value to zero - Replace effect RMS calculations with a more efficient way of detecting silent buffers - Only perform silent buffer detection when `ProcessStatus::ContinueIfNotQuiet` is returned from a plugin AND auto-quit is enabled Minor changes: - Remove gate from presets - Remove gate from .mmp projects - Move `Effect::processorCount()` to `LadspaEffect` - Rename `Effect::checkGate` to `Effect::handleAutoQuit` - Adjust silence threshold for better compatibility with old RMS calculations - Remove some unnecessary methods from `Effect` - Reset quiet buffer count in `stopRunning` - Use positive name for auto-quit boolean - Simplify `m_autoQuitEnabled` initialization
1 parent 71ce49d commit c86fe78

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+218
-236
lines changed

data/presets/AudioFileProcessor/Erazor.xpf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="100" arprange="2" arptime_denominator="4" syncmode="0" arpmode="0" arp-enabled="0" arp="0" arptime_numerator="4" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="127" readable="0"/>
1818
<fxchain numofeffects="3" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols ports="4">
2121
<port02 data="0.50197"/>
2222
<port03 data="0.3745"/>
@@ -28,7 +28,7 @@
2828
<attribute value="Plate2x2" name="plugin"/>
2929
</key>
3030
</effect>
31-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" gate="0" name="ladspaeffect" wet="1" on="1">
31+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" name="ladspaeffect" wet="1" on="1">
3232
<ladspacontrols link="1" ports="6">
3333
<port00 data_numerator="4" data_denominator="4" syncmode="0" link="1" data="200"/>
3434
<port01 link="1" data="0.24"/>
@@ -42,7 +42,7 @@
4242
<attribute value="fbdelay_5s" name="plugin"/>
4343
</key>
4444
</effect>
45-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="bassbooster" wet="1" on="1">
45+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="bassbooster" wet="1" on="1">
4646
<bassboostercontrols ratio="2" freq="100" gain="1"/>
4747
<key/>
4848
</effect>

data/presets/AudioFileProcessor/SString.xpf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="100" arprange="1" arptime_denominator="4" syncmode="0" arpmode="0" arp-enabled="0" arp="0" arptime_numerator="4" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="127" readable="0"/>
1818
<fxchain numofeffects="4" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols ports="4">
2121
<port02 data="0.005"/>
2222
<port03 data="0.749"/>
@@ -28,11 +28,11 @@
2828
<attribute value="Plate2x2" name="plugin"/>
2929
</key>
3030
</effect>
31-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="stereomatrix" wet="0.35" on="1">
31+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="stereomatrix" wet="0.35" on="1">
3232
<stereomatrixcontrols l-l="-0.5" l-r="-0.5" r-l="-0.5" r-r="-0.5"/>
3333
<key/>
3434
</effect>
35-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="400" gate="0" name="ladspaeffect" wet="1" on="1">
35+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="400" name="ladspaeffect" wet="1" on="1">
3636
<ladspacontrols link="0" ports="8">
3737
<port01 link="0" data="0.08"/>
3838
<port02 link="1" data="1"/>
@@ -48,7 +48,7 @@
4848
<attribute value="PhaserII" name="plugin"/>
4949
</key>
5050
</effect>
51-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
51+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
5252
<ladspacontrols link="1" ports="20">
5353
<port01 link="1" data="-48"/>
5454
<port02 link="1" data="-23.94"/>

data/presets/AudioFileProcessor/orion.xpf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="100" arprange="1" arptime_denominator="4" syncmode="0" arpmode="0" arp-enabled="0" arp="0" arptime_numerator="4" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="127" readable="0"/>
1818
<fxchain numofeffects="3" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols link="1" ports="8">
2121
<port00 link="1" data="-24"/>
2222
<port01 link="1" data="15995"/>
@@ -32,7 +32,7 @@
3232
<attribute value="tap_deesser" name="plugin"/>
3333
</key>
3434
</effect>
35-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" gate="0" name="ladspaeffect" wet="-1" on="1">
35+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" name="ladspaeffect" wet="-1" on="1">
3636
<ladspacontrols ports="4">
3737
<port02 data="0.99897"/>
3838
<port03 data="0.749"/>
@@ -44,7 +44,7 @@
4444
<attribute value="Plate2x2" name="plugin"/>
4545
</key>
4646
</effect>
47-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="stereomatrix" wet="0.2" on="1">
47+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="stereomatrix" wet="0.2" on="1">
4848
<stereomatrixcontrols l-l="-0.5" l-r="-0.5" r-l="-0.5" r-r="-0.5"/>
4949
<key/>
5050
</effect>

data/presets/BitInvader/alien_strings.xpf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<midiport inputchannel="0" outputchannel="1" send="0" receive="0"/>
1515
<chordcreator chorddisabled="1" arptime="107" arprange="1" arpsyncmode="6" arpmode="1" chord="0" chordrange="4" arp="74" arp-enabled="0" chord-enabled="0" arpdisabled="1" arpdir="0" arpgate="100"/>
1616
<fxchain enabled="1" numofeffects="1">
17-
<effect name="ladspaeffect" on="1" autoquit="1" autoquit_denominator="4" autoquit_numerator="4" wet="1" autoquit_syncmode="0" gate="0">
17+
<effect name="ladspaeffect" on="1" autoquit="1" autoquit_denominator="4" autoquit_numerator="4" wet="1" autoquit_syncmode="0">
1818
<ladspacontrols ports="0" link="1"/>
1919
<key>
2020
<attribute name="file" value="dc_remove_1207"/>

data/presets/BitInvader/drama.xpf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<midiport inputchannel="0" outputchannel="1" send="0" receive="0"/>
1515
<chordcreator chorddisabled="1" arptime="107" arprange="1" arpsyncmode="6" arpmode="1" chord="0" chordrange="4" arp="74" arp-enabled="1" chord-enabled="0" arpdisabled="0" arpdir="0" arpgate="100"/>
1616
<fxchain enabled="1" numofeffects="1">
17-
<effect name="ladspaeffect" on="1" autoquit="1" autoquit_denominator="4" autoquit_numerator="4" wet="1" autoquit_syncmode="0" gate="0">
17+
<effect name="ladspaeffect" on="1" autoquit="1" autoquit_denominator="4" autoquit_numerator="4" wet="1" autoquit_syncmode="0">
1818
<ladspacontrols ports="0" link="1"/>
1919
<key>
2020
<attribute name="file" value="dc_remove_1207"/>

data/presets/BitInvader/invaders_must_die.xpf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="27" arprange="2" arptime_denominator="16" syncmode="8" arpmode="0" arp-enabled="1" arp="0" arptime_numerator="1" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="63" readable="0"/>
1818
<fxchain numofeffects="2" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols ports="4">
2121
<port02 data="0.99897"/>
2222
<port03 data="0.749"/>
@@ -28,7 +28,7 @@
2828
<attribute value="Plate2x2" name="plugin"/>
2929
</key>
3030
</effect>
31-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="stereoenhancer" wet="1" on="0">
31+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="stereoenhancer" wet="1" on="0">
3232
<stereoenhancercontrols width="42"/>
3333
<key/>
3434
</effect>

data/presets/BitInvader/pluck.xpf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<midiport inports="80:0 CS46XX:CS46XX" inputchannel="0" outputchannel="1" send="0" receive="1"/>
1515
<chordcreator chorddisabled="0" arptime="100" arprange="1" arpsyncmode="0" arpmode="0" chord="0" chordrange="2" arp="0" arp-enabled="0" chord-enabled="1" arpdisabled="1" arpdir="0" arpgate="100"/>
1616
<fxchain enabled="1" numofeffects="1">
17-
<effect name="ladspaeffect" on="1" autoquit="1" autoquit_denominator="4" autoquit_numerator="4" wet="1" autoquit_syncmode="0" gate="0">
17+
<effect name="ladspaeffect" on="1" autoquit="1" autoquit_denominator="4" autoquit_numerator="4" wet="1" autoquit_syncmode="0">
1818
<ladspacontrols ports="0" link="1"/>
1919
<key>
2020
<attribute name="file" value="dc_remove_1207"/>

data/presets/Kicker/Clap dry.xpf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="100" arprange="1" arptime_denominator="4" syncmode="0" arpmode="0" scale_type="linear" arp-enabled="0" arp="0" arptime_numerator="4" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" scale_type="linear" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="63" readable="0"/>
1818
<fxchain numofeffects="2" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" scale_type="linear" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" scale_type="linear" autoquit="1" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols ports="10">
2121
<port02 scale_type="linear" data="-47.97"/>
2222
<port03 scale_type="linear" data="0"/>
@@ -34,7 +34,7 @@
3434
<attribute value="Eq2x2" name="plugin"/>
3535
</key>
3636
</effect>
37-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" scale_type="linear" autoquit="1" gate="0" name="dualfilter" wet="1" on="1">
37+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" scale_type="linear" autoquit="1" name="dualfilter" wet="1" on="1">
3838
<DualFilterControls gain2="100" cut1="1721" cut2="6461" mix="-0.4" res1="1.64" res2="0.5" scale_type="linear" filter1="0" filter2="1" enabled1="1" enabled2="1" gain1="100"/>
3939
<key/>
4040
</effect>

data/presets/Kicker/Clap.xpf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="100" arprange="1" arptime_denominator="4" syncmode="0" arpmode="0" arp-enabled="0" arp="0" arptime_numerator="4" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="63" readable="0"/>
1818
<fxchain numofeffects="2" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols ports="10">
2121
<port02 data="0"/>
2222
<port03 data="0"/>
@@ -34,7 +34,7 @@
3434
<attribute value="Eq2x2" name="plugin"/>
3535
</key>
3636
</effect>
37-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" gate="0" name="ladspaeffect" wet="1" on="1">
37+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="8000" name="ladspaeffect" wet="1" on="1">
3838
<ladspacontrols ports="4">
3939
<port02 data="0.121765"/>
4040
<port03 data="0.10486"/>

data/presets/Kicker/SnareMarch.xpf

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<arpeggiator arptime="100" arprange="1" arptime_denominator="4" syncmode="0" arpmode="0" arp-enabled="0" arp="0" arptime_numerator="4" arpdir="0" arpgate="100"/>
1717
<midiport inputcontroller="0" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="63" readable="0"/>
1818
<fxchain numofeffects="6" enabled="1">
19-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
19+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
2020
<ladspacontrols ports="10">
2121
<port02 data="0"/>
2222
<port03 data="0"/>
@@ -34,7 +34,7 @@
3434
<attribute value="Eq2x2" name="plugin"/>
3535
</key>
3636
</effect>
37-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="0.5" on="0">
37+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="0.5" on="0">
3838
<ladspacontrols ports="4">
3939
<port02 data="0.370265"/>
4040
<port03 data="0"/>
@@ -46,7 +46,7 @@
4646
<attribute value="Plate2x2" name="plugin"/>
4747
</key>
4848
</effect>
49-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
49+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
5050
<ladspacontrols ports="9">
5151
<port07>
5252
<data scale_type="log" value="0.4" id="6315252"/>
@@ -71,7 +71,7 @@
7171
<attribute value="Reverb" name="plugin"/>
7272
</key>
7373
</effect>
74-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="0.18" on="1">
74+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="0.18" on="1">
7575
<ladspacontrols ports="13">
7676
<port04 data="0"/>
7777
<port05 data="1.02375"/>
@@ -104,7 +104,7 @@
104104
<attribute value="Saturator" name="plugin"/>
105105
</key>
106106
</effect>
107-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
107+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
108108
<ladspacontrols ports="13">
109109
<port04 data="0"/>
110110
<port05 data="1.02375"/>
@@ -137,7 +137,7 @@
137137
<attribute value="Saturator" name="plugin"/>
138138
</key>
139139
</effect>
140-
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
140+
<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" name="ladspaeffect" wet="1" on="1">
141141
<ladspacontrols ports="10">
142142
<port02 data="-47.97"/>
143143
<port03 data="-10.8"/>

0 commit comments

Comments
 (0)