Preparation for release of v0.5.

Author: Michael Barr

README.rst

@@ -97,7 +97,7 @@ Imagine you have the models ``Location`` and ``LocationReportingPeriod``:
         )
 
 
-    def _get_reporting_period_timzone(obj):
+    def _get_reporting_period_timezone(obj):
         """Called as `obj` being the LocationReportingPeriodInstance.
 
         Note:
@@ -117,13 +117,13 @@ Imagine you have the models ``Location`` and ``LocationReportingPeriod``:
             verbose_name=_('start'),
             # populate_from can also be a string value, provided that the string value
             #   is a field on the same model
-            populate_from=_get_reporting_period_timzone,
+            populate_from=_get_reporting_period_timezone,
             # Time override must be a datetime.time instance
             time_override=datetime.min.time(),
         )
         end = LinkedTZDateTimeField(
             verbose_name=_('end'),
-            populate_from=_get_reporting_period_timzone,
+            populate_from=_get_reporting_period_timezone,
             # Time override must be a datetime.time instance
             time_override=datetime.max.time(),
         )
@@ -253,7 +253,8 @@ Contributors
 
 Changelog
 ---------
-
+- 0.5 Bug fix: time override on datetime.min.time() failed to set time properly
+- 0.4 Removed support for Python 2.5
 - 0.3 Code cleanup.
 - 0.2 Multiple bug fixes based on testing.
 - 0.1 Initial release.

timezone_utils/__init__.py

@@ -1,2 +1,2 @@
-__version__ = (0, 4)
+__version__ = (0, 5)
 VERSION = '.'.join(map(str, __version__))

timezone_utils/fields.py

@@ -207,17 +207,20 @@ def pre_save(self, model_instance, add):
                 # It was a valiant effort. Resistance is futile.
                 raise
 
-            datetime_as_timezone = value.astimezone(tz)
-            value = tz.normalize(
-                tz.localize(
-                    datetime.combine(
-                        date=datetime_as_timezone.date(),
-                        time=datetime_as_timezone.time()
+            # We don't want to double-convert the value. This leads to incorrect
+            #   dates being generated when the overridden time goes back a day.
+            if self.time_override is None:
+                datetime_as_timezone = value.astimezone(tz)
+                value = tz.normalize(
+                    tz.localize(
+                        datetime.combine(
+                            date=datetime_as_timezone.date(),
+                            time=datetime_as_timezone.time()
+                        )
                     )
                 )
-            )
 
-        if self.time_override and not (
+        if self.time_override is not None and not (
             self.auto_now or (self.auto_now_add and add)
         ):
             if callable(self.time_override):
@@ -226,7 +229,9 @@ def pre_save(self, model_instance, add):
                 time_override = self.time_override
 
             if not isinstance(time_override, datetime_time):
-                raise ValidationError('meh')
+                raise ValueError(
+                    'Invalid type. Must be a datetime.time instance.'
+                )
 
             value = tz.normalize(
                 tz.localize(