Skip to content

Commit b930654

Browse files
Further pylint corrections.
1 parent 564ed94 commit b930654

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

timezone_utils/fields.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,17 @@
3232
# ==============================================================================
3333
# MODEL FIELDS
3434
# ==============================================================================
35-
# pylint: disable=E0239
36-
class TimeZoneField(with_metaclass(TimeZoneFieldBase, CharField)):
35+
class TimeZoneField(
36+
with_metaclass(TimeZoneFieldBase, CharField)
37+
): # pylint: disable=E0239
3738
# Enforce the minimum length of max_length to be the length of the longest
3839
# pytz timezone string
3940
MIN_LENGTH = max(map(len, pytz.all_timezones))
4041
default_error_messages = {
4142
'invalid': _("'%(value)s' is not a valid time zone."),
4243
}
4344

45+
# pylint: disable=newstyle
4446
def __init__(self, *args, **kwargs):
4547
# Retrieve the model field's declared max_length or default to pytz's
4648
# maximum length
@@ -61,7 +63,6 @@ def __init__(self, *args, **kwargs):
6163
category=UserWarning,
6264
)
6365

64-
# pylint: disable=newstyle
6566
super(TimeZoneField, self).__init__(*args, **kwargs)
6667

6768
def validate(self, value, model_instance):
@@ -119,6 +120,7 @@ def to_python(self, value):
119120
params={'value': value}
120121
)
121122

123+
# pylint: disable=E0239
122124
def formfield(self, **kwargs):
123125
"""Returns a custom form field for the TimeZoneField."""
124126

@@ -129,6 +131,7 @@ def formfield(self, **kwargs):
129131
# --------------------------------------------------------------------------
130132
# Django >= 1.7 Checks Framework
131133
# --------------------------------------------------------------------------
134+
# pylint: disable=E0239
132135
def check(self, **kwargs): # pragma: no cover
133136
"""Calls the TimeZoneField's custom checks."""
134137

@@ -227,19 +230,23 @@ def _check_choices_attribute(self): # pragma: no cover
227230
return []
228231

229232

230-
# pylint: disable=E0239
231-
class LinkedTZDateTimeField(with_metaclass(TimeZoneFieldBase, DateTimeField)):
233+
class LinkedTZDateTimeField(
234+
with_metaclass(TimeZoneFieldBase, DateTimeField)
235+
): # pylint: disable=E0239
236+
# pylint: disable=newstyle
232237
def __init__(self, *args, **kwargs):
233238
self.populate_from = kwargs.pop('populate_from', None)
234239
self.time_override = kwargs.pop('time_override', None)
235240
self.timezone = get_default_timezone()
236241

237-
# pylint: disable=newstyle
238242
super(LinkedTZDateTimeField, self).__init__(*args, **kwargs)
239243

240-
def from_db_value(self, value, expression, connection, context): # noqa
244+
def from_db_value(self, value, expression, connection, context):
245+
# pylint: disable=W0613
241246
if value:
242247
value = self.to_python(value)
248+
249+
243250
return value
244251

245252
def to_python(self, value):
@@ -283,7 +290,7 @@ def pre_save(self, model_instance, add):
283290

284291
def deconstruct(self): # pragma: no cover
285292
"""Add our custom keyword arguments for migrations."""
286-
293+
# pylint: disable=newstyle
287294
name, path, args, kwargs = super(
288295
LinkedTZDateTimeField,
289296
self

0 commit comments

Comments
 (0)