Fixes for github artifact upload (#103)

* Upgrade npm package upload artifact actions
* Update to v4 of actions/upload-artifact
* Update code to support changes in latest artifact upload.

* Ensure each workflow job has a unique artifact name (Required for v4 artifact upload)

Author: michaelkaye

.github/workflows/check-dist.yml

@@ -44,7 +44,7 @@ jobs:
         id: diff
 
       # If index.js was different than expected, upload the expected version as an artifact
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: ${{ failure() && steps.diff.conclusion == 'failure' }}
         with:
           name: dist

.github/workflows/test.yml

@@ -23,6 +23,7 @@ jobs:
       uses: ./
       with: 
         uploadLogs: true
+        artifactName: synapse-logs-${{ github.job }}
         httpPort: 8008
 
   test-poetry-branch:
@@ -36,6 +37,7 @@ jobs:
       uses: ./
       with: 
         uploadLogs: true
+        artifactName: synapse-logs-${{ github.job }}
         httpPort: 8008
         installer: "poetry"
         version: "master"
@@ -51,6 +53,7 @@ jobs:
       uses: ./
       with: 
         uploadLogs: true
+        artifactName: synapse-logs-${{ github.job }}
         httpPort: 8008
         installer: "poetry"
 
@@ -65,6 +68,7 @@ jobs:
       uses: ./
       with: 
         uploadLogs: true
+        artifactName: synapse-logs-${{ github.job }}
         httpPort: 8008
         public_baseurl: http://10.0.2.2:8008/
 
@@ -80,6 +84,7 @@ jobs:
       with: 
         installer: poetry
         uploadLogs: true
+        artifactName: synapse-logs-${{ github.job }}
         httpPort: 8008
         customModules: "git+https://github.com/michaelkaye/noop-synapse-storage-provider.git"
         customConfig: | 
@@ -104,6 +109,7 @@ jobs:
       uses: ./
       with: 
         uploadLogs: true
+        artifactName: synapse-logs-${{ github.job }}
         httpPort: 8008
         customModules: "git+https://github.com/michaelkaye/noop-synapse-storage-provider.git#egg=noop-synapse-storage-provider"
         customConfig: | 

destroy.js

@@ -1,6 +1,6 @@
 const core = require('@actions/core');
 const process = require('process');
-const artifact = require('@actions/artifact');
+const {DefaultArtifactClient} = require('@actions/artifact');
 
 // most @actions toolkit packages have async methods
 async function run() {
@@ -26,8 +26,8 @@ async function run() {
     // (useful for an artifact upload)
     const upload = core.getBooleanInput('uploadLogs', {required: true});
     if (upload) {
+      const artifact = new DefaultArtifactClient();
       const artifactName = core.getInput('artifactName');
-      const artifactClient = artifact.create();
       const files = [
         `${cwd}/homeserver.yaml`,
         `${cwd}/homeserver.log`,
@@ -41,7 +41,7 @@ async function run() {
       const options = {
         continueOnError: true
       }
-      await artifactClient.uploadArtifact(artifactName, files, rootDirectory, options);
+      await artifact.uploadArtifact(artifactName, files, rootDirectory, options);
     }
   } catch (error) {
     core.setFailed(error.message);