Skip to content

Commit 79e6208

Browse files
author
Ryon
committed
Update to Spring-Data 2.1.2.RELEASE and Spring Framework 5.1.2.RELEASE
This required enabling Mockito mocking of final classes, adapting to a single changed Spring-Data class name, and updating unit tests to compensate.
1 parent cc5486c commit 79e6208

File tree

6 files changed

+15
-10
lines changed

6 files changed

+15
-10
lines changed

pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<modelVersion>4.0.0</modelVersion>
2121
<groupId>com.github.derjust</groupId>
2222
<artifactId>spring-data-dynamodb</artifactId>
23-
<version>5.0.4-SNAPSHOT</version>
23+
<version>5.1.4-SNAPSHOT</version>
2424
<name>Spring Data DynamoDB</name>
2525
<inceptionYear>2018</inceptionYear>
2626

@@ -37,13 +37,13 @@
3737
</licenses>
3838

3939
<properties>
40-
<spring.version>5.0.4.RELEASE</spring.version>
41-
<spring-data.version>2.0.9.RELEASE</spring-data.version>
40+
<spring.version>5.1.2.RELEASE</spring.version>
41+
<spring-data.version>2.1.2.RELEASE</spring-data.version>
4242

4343
<hibernate-validator.version>6.0.9.Final</hibernate-validator.version>
44-
<aws-java-sdk.version>1.11.301</aws-java-sdk.version>
44+
<aws-java-sdk.version>1.11.443</aws-java-sdk.version>
4545
<junit.version>4.12</junit.version>
46-
<mockito.version>2.13.0</mockito.version>
46+
<mockito.version>2.23.0</mockito.version>
4747

4848
<cdi.version>1.2</cdi.version>
4949
<slf4j-test.version>1.2.0</slf4j-test.version>

src/changes/changes.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@
2323
<author email="[email protected]">derjust</author>
2424
</properties>
2525
<body>
26+
<release version="5.1.4" date="" description="Maintenance &amp; security release">
27+
<action dev="ryonday" issue="218" type="fix" date="2018-11-09">
28+
Update to Spring-Data 2.1.2.RELEASE and Spring Framework 5.1.2.RELEASE
29+
</action>
30+
</release>
2631
<release version="5.0.4" date="" description="Maintenance &amp; security release">
2732
<action dev="enriquezrene" issue="199" type="fix" date="2018-10-11">
2833
Fix README.md examples

src/main/java/org/socialsignin/spring/data/dynamodb/repository/support/DynamoDBRepositoryFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.springframework.data.repository.core.RepositoryInformation;
2626
import org.springframework.data.repository.core.RepositoryMetadata;
2727
import org.springframework.data.repository.core.support.RepositoryFactorySupport;
28-
import org.springframework.data.repository.query.EvaluationContextProvider;
28+
import org.springframework.data.repository.query.QueryMethodEvaluationContextProvider;
2929
import org.springframework.data.repository.query.QueryLookupStrategy;
3030
import org.springframework.data.repository.query.QueryLookupStrategy.Key;
3131
import org.springframework.data.util.Version;
@@ -108,7 +108,7 @@ public <T, ID> DynamoDBEntityInformation<T, ID> getEntityInformation(final Class
108108

109109
@Override
110110
protected Optional<QueryLookupStrategy> getQueryLookupStrategy(Key key,
111-
EvaluationContextProvider evaluationContextProvider) {
111+
QueryMethodEvaluationContextProvider evaluationContextProvider) {
112112
return Optional.of(DynamoDBQueryLookupStrategy.create(dynamoDBOperations, key));
113113
}
114114

src/test/java/org/socialsignin/spring/data/dynamodb/domain/UnpagedPageImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void testHashCode() {
9494
public void testToString() {
9595
String actual = underTest.toString();
9696

97-
assertTrue(actual, actual.startsWith("Page 1 of 1 containing codegen.java.util.Iterator$MockitoMock"));
97+
assertTrue(actual, actual.startsWith("Page 1 of 1 containing org.mockito.codegen.Iterator$MockitoMock"));
9898
}
9999

100100
@Test

src/test/java/org/socialsignin/spring/data/dynamodb/repository/query/PartTreeDynamoDBQueryUnitTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,7 @@ private <T, ID extends Serializable> void setupCommonMocksForThisRepositoryMetho
147147
// https://github.com/mockito/mockito/wiki/FAQ#what-are-the-limitations-of-mockito
148148
// Therefore setting the field explicitly that is used by all the isXXX methods
149149
try {
150-
Field unwrappedReturnTypeField = mockDynamoDBQueryMethod.getClass() // Mockito-generated class
151-
.getSuperclass() // org.socialsignin.spring.data.dynamodb.repository.query.DynamoDBQueryMethod
150+
Field unwrappedReturnTypeField = mockDynamoDBQueryMethod.getClass() // org.socialsignin.spring.data.dynamodb.repository.query.DynamoDBQueryMethod
152151
.getSuperclass() // org.springframework.data.repository.query.QueryMethod
153152
.getDeclaredField("unwrappedReturnType");
154153
unwrappedReturnTypeField.setAccessible(true); // It's final therefore unlocking the field
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
mock-maker-inline

0 commit comments

Comments
 (0)